diff options
Diffstat (limited to 'src/codegen')
| -rw-r--r-- | src/codegen/c.zig | 145 |
1 files changed, 103 insertions, 42 deletions
diff --git a/src/codegen/c.zig b/src/codegen/c.zig index 4b7ac15b94..d6151d337b 100644 --- a/src/codegen/c.zig +++ b/src/codegen/c.zig @@ -258,6 +258,42 @@ pub fn fmtIdent(ident: []const u8) std.fmt.Formatter(formatIdent) { return .{ .data = ident }; } +// Returns true if `formatIdent` would make any edits to ident. +// This must be kept in sync with `formatIdent`. +pub fn isMangledIdent(ident: []const u8, solo: bool) bool { + if (solo and isReservedIdent(ident)) return true; + for (ident, 0..) |c, i| { + switch (c) { + 'a'...'z', 'A'...'Z', '_' => {}, + '0'...'9' => if (i == 0) return true, + else => return true, + } + } + return false; +} + +const DeclVisibility = enum { + global, + global_mangled, + local, + + fn renderFwd(visibility: DeclVisibility, w: anytype) !void { + try w.writeAll(switch (visibility) { + .global => "zig_extern ", + // MSVC doesn't support exporting `static` functions, so they need special treatment + .global_mangled => "zig_extern_mangled ", + .local => "static ", + }); + } + + fn renderDef(visibility: DeclVisibility, w: anytype) !void { + return switch (visibility) { + .global => {}, + else => visibility.renderFwd(w), + }; + } +}; + /// This data is available when outputting .c code for a `InternPool.Index` /// that corresponds to `func`. /// It is not available when generating .h file. @@ -530,6 +566,7 @@ pub const DeclGen = struct { is_naked_fn: bool, /// This is a borrowed reference from `link.C`. fwd_decl: std.ArrayList(u8), + error_msg: ?*Module.ErrorMsg, ctypes: CType.Store, /// Keeps track of anonymous decls that need to be rendered before this @@ -1631,7 +1668,7 @@ pub const DeclGen = struct { switch (name) { .export_index => |export_index| try dg.renderDeclName(w, fn_decl_index, export_index), - .string => |string| try w.writeAll(string), + .string => |string| try w.print("{ }", .{fmtIdent(string)}), } try renderTypeSuffix( @@ -1843,12 +1880,26 @@ pub const DeclGen = struct { try renderTypeSuffix(dg.pass, store.*, mod, w, cty_idx, .suffix, .{}); } - fn declIsGlobal(dg: *DeclGen, tv: TypedValue) bool { + fn declVisibility(dg: *DeclGen, tv: TypedValue) DeclVisibility { const mod = dg.module; return switch (mod.intern_pool.indexToKey(tv.val.ip_index)) { - .variable => |variable| mod.decl_exports.contains(variable.decl), - .extern_func => true, - .func => |func| mod.decl_exports.contains(func.owner_decl), + .variable => |variable| { + if (mod.decl_exports.get(variable.decl)) |exports| { + return if (isMangledIdent(dg.module.intern_pool.stringToSlice(exports.items[0].opts.name), true)) + .global_mangled + else + .global; + } else return .local; + }, + .extern_func => .global, + .func => |func| { + if (mod.decl_exports.get(func.owner_decl)) |exports| { + return if (isMangledIdent(dg.module.intern_pool.stringToSlice(exports.items[0].opts.name), true)) + .global_mangled + else + .global; + } else return .local; + }, else => unreachable, }; } @@ -1933,8 +1984,8 @@ pub const DeclGen = struct { fn renderFwdDecl(dg: *DeclGen, decl_index: InternPool.DeclIndex, variable: InternPool.Key.Variable) !void { const decl = dg.module.declPtr(decl_index); const fwd = dg.fwd_decl.writer(); - const is_global = dg.declIsGlobal(.{ .ty = decl.ty, .val = decl.val }) or variable.is_extern; - try fwd.writeAll(if (is_global) "zig_extern " else "static "); + const visibility = if (variable.is_extern) .global else dg.declVisibility(.{ .ty = decl.ty, .val = decl.val }); + try visibility.renderFwd(fwd); const export_weak_linkage = if (dg.module.decl_exports.get(decl_index)) |exports| exports.items[0].opts.linkage == .Weak else @@ -1958,7 +2009,7 @@ pub const DeclGen = struct { try mod.markDeclAlive(decl); if (mod.decl_exports.get(decl_index)) |exports| { - try writer.print("{}", .{exports.items[export_index].opts.name.fmt(&mod.intern_pool)}); + try writer.print("{ }", .{fmtIdent(mod.intern_pool.stringToSlice(exports.items[export_index].opts.name))}); } else if (decl.getExternDecl(mod).unwrap()) |extern_decl_index| { try writer.print("{}", .{mod.declPtr(extern_decl_index).name.fmt(&mod.intern_pool)}); } else { @@ -2598,16 +2649,19 @@ fn genExports(o: *Object) !void { const fwd = o.dg.fwd_decl.writer(); const exports = mod.decl_exports.get(decl_index) orelse return; - if (exports.items.len < 2) return; + + const is_mangled = isMangledIdent(ip.stringToSlice(exports.items[0].opts.name), true); + if (exports.items.len < 2 and !is_mangled) return; switch (ip.indexToKey(tv.val.toIntern())) { .func => { - for (exports.items[1..], 1..) |@"export", i| { + const start_i = 1 - @intFromBool(is_mangled); + for (exports.items[start_i..], start_i..) |@"export", i| { try fwd.writeAll("zig_export("); if (exports.items[i].opts.linkage == .Weak) try fwd.writeAll("zig_weak_linkage_fn "); try o.dg.renderFunctionSignature(fwd, decl_index, .forward, .{ .export_index = @as(u32, @intCast(i)) }); - try fwd.print(", {s}, {s});\n", .{ - fmtStringLiteral(ip.stringToSlice(exports.items[0].opts.name), null), + try fwd.print(", { }, {s});\n", .{ + fmtIdent(ip.stringToSlice(exports.items[0].opts.name)), fmtStringLiteral(ip.stringToSlice(@"export".opts.name), null), }); } @@ -2617,7 +2671,8 @@ fn genExports(o: *Object) !void { unreachable; }, .variable => |variable| { - for (exports.items[1..], 1..) |@"export", i| { + const start_i = 1 - @intFromBool(is_mangled); + for (exports.items[start_i..], start_i..) |@"export", i| { try fwd.writeAll("zig_export("); if (exports.items[i].opts.linkage == .Weak) try fwd.writeAll("zig_weak_linkage "); const alias = ip.stringToSlice(@"export".opts.name); @@ -2629,8 +2684,8 @@ fn genExports(o: *Object) !void { decl.alignment, .complete, ); - try fwd.print(", {s}, {s});\n", .{ - fmtStringLiteral(ip.stringToSlice(exports.items[0].opts.name), null), + try fwd.print(", { }, {s});\n", .{ + fmtIdent(ip.stringToSlice(exports.items[0].opts.name)), fmtStringLiteral(alias, null), }); } @@ -2742,9 +2797,10 @@ pub fn genFunc(f: *Function) !void { o.code_header = std.ArrayList(u8).init(gpa); defer o.code_header.deinit(); - const is_global = o.dg.declIsGlobal(tv); + const visibility = o.dg.declVisibility(tv); const fwd_decl_writer = o.dg.fwd_decl.writer(); - try fwd_decl_writer.writeAll(if (is_global) "zig_extern " else "static "); + try visibility.renderFwd(fwd_decl_writer); + if (mod.decl_exports.get(decl_index)) |exports| if (exports.items[0].opts.linkage == .Weak) try fwd_decl_writer.writeAll("zig_weak_linkage_fn "); try o.dg.renderFunctionSignature(fwd_decl_writer, decl_index, .forward, .{ .export_index = 0 }); @@ -2752,7 +2808,7 @@ pub fn genFunc(f: *Function) !void { try genExports(o); try o.indent_writer.insertNewline(); - if (!is_global) try o.writer().writeAll("static "); + try visibility.renderDef(o.writer()); try o.dg.renderFunctionSignature(o.writer(), decl_index, .complete, .{ .export_index = 0 }); try o.writer().writeByte(' '); @@ -2836,9 +2892,9 @@ pub fn genDecl(o: *Object) !void { if (variable.is_extern) return; - const is_global = o.dg.declIsGlobal(tv) or variable.is_extern; + const visibility = if (variable.is_extern) .global else o.dg.declVisibility(tv); const w = o.writer(); - if (!is_global) try w.writeAll("static "); + try visibility.renderDef(w); if (variable.is_weak_linkage) try w.writeAll("zig_weak_linkage "); if (variable.is_threadlocal) try w.writeAll("zig_threadlocal "); if (mod.intern_pool.stringToSliceUnwrap(decl.@"linksection")) |s| @@ -2851,16 +2907,21 @@ pub fn genDecl(o: *Object) !void { try w.writeByte(';'); try o.indent_writer.insertNewline(); } else { - const is_global = o.dg.module.decl_exports.contains(decl_index); + const visibility: DeclVisibility = if (o.dg.module.decl_exports.get(decl_index)) |exports| b: { + break :b if (isMangledIdent(o.dg.module.intern_pool.stringToSlice(exports.items[0].opts.name), true)) + .global_mangled + else + .global; + } else .local; const decl_c_value = .{ .decl = decl_index }; - return genDeclValue(o, tv, is_global, decl_c_value, decl.alignment, decl.@"linksection"); + return genDeclValue(o, tv, visibility, decl_c_value, decl.alignment, decl.@"linksection"); } } pub fn genDeclValue( o: *Object, tv: TypedValue, - is_global: bool, + visibility: DeclVisibility, decl_c_value: CValue, alignment: Alignment, link_section: InternPool.OptionalNullTerminatedString, @@ -2868,12 +2929,13 @@ pub fn genDeclValue( const mod = o.dg.module; const fwd_decl_writer = o.dg.fwd_decl.writer(); - try fwd_decl_writer.writeAll(if (is_global) "zig_extern " else "static "); + try visibility.renderFwd(fwd_decl_writer); try o.dg.renderTypeAndName(fwd_decl_writer, tv.ty, decl_c_value, Const, alignment, .complete); try fwd_decl_writer.writeAll(";\n"); const w = o.writer(); - if (!is_global) try w.writeAll("static "); + try visibility.renderDef(w); + if (mod.intern_pool.stringToSliceUnwrap(link_section)) |s| try w.print("zig_linksection(\"{s}\", ", .{s}); try o.dg.renderTypeAndName(w, tv.ty, decl_c_value, Const, alignment, .complete); @@ -2898,11 +2960,14 @@ pub fn genHeader(dg: *DeclGen) error{ AnalysisFail, OutOfMemory }!void { switch (tv.ty.zigTypeTag(mod)) { .Fn => { - const is_global = dg.declIsGlobal(tv); - if (is_global) { - try writer.writeAll("zig_extern "); - try dg.renderFunctionSignature(writer, dg.pass.decl, .complete, .{ .export_index = 0 }); - try dg.fwd_decl.appendSlice(";\n"); + const visibility = dg.declVisibility(tv); + switch (visibility) { + .global, .global_mangled => { + try visibility.renderFwd(writer); + try dg.renderFunctionSignature(writer, dg.pass.decl, .complete, .{ .export_index = 0 }); + try dg.fwd_decl.appendSlice(";\n"); + }, + .local => {}, } }, else => {}, @@ -6895,9 +6960,9 @@ fn airReduce(f: *Function, inst: Air.Inst.Index) !CValue { try f.writeCValue(writer, accum, .Other); switch (op) { .float_op => |func| { - try writer.writeAll(" = zig_libc_name_"); + try writer.writeAll(" = zig_float_fn_"); try f.object.dg.renderTypeForBuiltinFnName(writer, scalar_ty); - try writer.print("({s})(", .{func.operation}); + try writer.print("_{s}(", .{func.operation}); try f.writeCValue(writer, accum, .FunctionArgument); try writer.writeAll(", "); try f.writeCValue(writer, operand, .Other); @@ -7229,11 +7294,9 @@ fn unFloatOp(f: *Function, inst: Air.Inst.Index, operand: CValue, ty: Type, oper const v = try Vectorize.start(f, inst, writer, ty); try f.writeCValue(writer, local, .Other); try v.elem(f, writer); - try writer.writeAll(" = zig_libc_name_"); + try writer.writeAll(" = zig_float_fn_"); try f.object.dg.renderTypeForBuiltinFnName(writer, scalar_ty); - try writer.writeByte('('); - try writer.writeAll(operation); - try writer.writeAll(")("); + try writer.print("_{s}(", .{operation}); try f.writeCValue(writer, operand, .FunctionArgument); try v.elem(f, writer); try writer.writeAll(");\n"); @@ -7268,11 +7331,9 @@ fn airBinFloatOp(f: *Function, inst: Air.Inst.Index, operation: []const u8) !CVa const v = try Vectorize.start(f, inst, writer, inst_ty); try f.writeCValue(writer, local, .Other); try v.elem(f, writer); - try writer.writeAll(" = zig_libc_name_"); + try writer.writeAll(" = zig_float_fn_"); try f.object.dg.renderTypeForBuiltinFnName(writer, inst_scalar_ty); - try writer.writeByte('('); - try writer.writeAll(operation); - try writer.writeAll(")("); + try writer.print("_{s}(", .{operation}); try f.writeCValue(writer, lhs, .FunctionArgument); try v.elem(f, writer); try writer.writeAll(", "); @@ -7302,9 +7363,9 @@ fn airMulAdd(f: *Function, inst: Air.Inst.Index) !CValue { const v = try Vectorize.start(f, inst, writer, inst_ty); try f.writeCValue(writer, local, .Other); try v.elem(f, writer); - try writer.writeAll(" = zig_libc_name_"); + try writer.writeAll(" = zig_float_fn_"); try f.object.dg.renderTypeForBuiltinFnName(writer, inst_scalar_ty); - try writer.writeAll("(fma)("); + try writer.writeAll("_fma("); try f.writeCValue(writer, mulend1, .FunctionArgument); try v.elem(f, writer); try writer.writeAll(", "); |
