diff options
Diffstat (limited to 'src/arch')
| -rw-r--r-- | src/arch/aarch64/abi.zig | 62 | ||||
| -rw-r--r-- | src/arch/arm/abi.zig | 154 | ||||
| -rw-r--r-- | src/arch/riscv64/abi.zig | 69 | ||||
| -rw-r--r-- | src/arch/x86_64/CodeGen.zig | 2 | ||||
| -rw-r--r-- | src/arch/x86_64/abi.zig | 24 |
5 files changed, 283 insertions, 28 deletions
diff --git a/src/arch/aarch64/abi.zig b/src/arch/aarch64/abi.zig index 7c92d4e91c..e83cc0444a 100644 --- a/src/arch/aarch64/abi.zig +++ b/src/arch/aarch64/abi.zig @@ -5,41 +5,54 @@ const Register = bits.Register; const RegisterManagerFn = @import("../../register_manager.zig").RegisterManager; const Type = @import("../../type.zig").Type; -pub const Class = enum(u8) { memory, integer, none, float_array, _ }; +pub const Class = union(enum) { + memory, + byval, + integer, + double_integer, + float_array: u8, +}; /// For `float_array` the second element will be the amount of floats. -pub fn classifyType(ty: Type, target: std.Target) [2]Class { - var maybe_float_bits: ?u16 = null; - const float_count = countFloats(ty, target, &maybe_float_bits); - if (float_count <= sret_float_count) return .{ .float_array, @intToEnum(Class, float_count) }; - return classifyTypeInner(ty, target); -} +pub fn classifyType(ty: Type, target: std.Target) Class { + std.debug.assert(ty.hasRuntimeBitsIgnoreComptime()); -fn classifyTypeInner(ty: Type, target: std.Target) [2]Class { - if (!ty.hasRuntimeBitsIgnoreComptime()) return .{ .none, .none }; + var maybe_float_bits: ?u16 = null; switch (ty.zigTypeTag()) { .Struct => { - if (ty.containerLayout() == .Packed) return .{ .integer, .none }; + if (ty.containerLayout() == .Packed) return .byval; + const float_count = countFloats(ty, target, &maybe_float_bits); + if (float_count <= sret_float_count) return .{ .float_array = float_count }; + const bit_size = ty.bitSize(target); - if (bit_size > 128) return .{ .memory, .none }; - if (bit_size > 64) return .{ .integer, .integer }; - return .{ .integer, .none }; + if (bit_size > 128) return .memory; + if (bit_size > 64) return .double_integer; + return .integer; }, .Union => { + if (ty.containerLayout() == .Packed) return .byval; + const float_count = countFloats(ty, target, &maybe_float_bits); + if (float_count <= sret_float_count) return .{ .float_array = float_count }; + + const bit_size = ty.bitSize(target); + if (bit_size > 128) return .memory; + if (bit_size > 64) return .double_integer; + return .integer; + }, + .Int, .Enum, .ErrorSet, .Float, .Bool => return .byval, + .Vector => { const bit_size = ty.bitSize(target); - if (bit_size > 128) return .{ .memory, .none }; - if (bit_size > 64) return .{ .integer, .integer }; - return .{ .integer, .none }; + // TODO is this controlled by a cpu feature? + if (bit_size > 128) return .memory; + return .byval; }, - .Int, .Enum, .ErrorSet, .Vector, .Float, .Bool => return .{ .integer, .none }, - .Array => return .{ .memory, .none }, .Optional => { std.debug.assert(ty.isPtrLikeOptional()); - return .{ .integer, .none }; + return .byval; }, .Pointer => { std.debug.assert(!ty.isSlice()); - return .{ .integer, .none }; + return .byval; }, .ErrorUnion, .Frame, @@ -55,17 +68,18 @@ fn classifyTypeInner(ty: Type, target: std.Target) [2]Class { .Fn, .Opaque, .EnumLiteral, + .Array, => unreachable, } } const sret_float_count = 4; -fn countFloats(ty: Type, target: std.Target, maybe_float_bits: *?u16) u32 { - const invalid = std.math.maxInt(u32); +fn countFloats(ty: Type, target: std.Target, maybe_float_bits: *?u16) u8 { + const invalid = std.math.maxInt(u8); switch (ty.zigTypeTag()) { .Union => { const fields = ty.unionFields(); - var max_count: u32 = 0; + var max_count: u8 = 0; for (fields.values()) |field| { const field_count = countFloats(field.ty, target, maybe_float_bits); if (field_count == invalid) return invalid; @@ -76,7 +90,7 @@ fn countFloats(ty: Type, target: std.Target, maybe_float_bits: *?u16) u32 { }, .Struct => { const fields_len = ty.structFieldCount(); - var count: u32 = 0; + var count: u8 = 0; var i: u32 = 0; while (i < fields_len) : (i += 1) { const field_ty = ty.structFieldType(i); diff --git a/src/arch/arm/abi.zig b/src/arch/arm/abi.zig index 3fcfb0e561..9659ca13d7 100644 --- a/src/arch/arm/abi.zig +++ b/src/arch/arm/abi.zig @@ -2,6 +2,160 @@ const std = @import("std"); const bits = @import("bits.zig"); const Register = bits.Register; const RegisterManagerFn = @import("../../register_manager.zig").RegisterManager; +const Type = @import("../../type.zig").Type; + +pub const Class = union(enum) { + memory, + byval, + i32_array: u8, + i64_array: u8, + + fn arrSize(total_size: u64, arr_size: u64) Class { + const count = @intCast(u8, std.mem.alignForward(total_size, arr_size) / arr_size); + if (arr_size == 32) { + return .{ .i32_array = count }; + } else { + return .{ .i64_array = count }; + } + } +}; + +pub const Context = enum { ret, arg }; + +pub fn classifyType(ty: Type, target: std.Target, ctx: Context) Class { + std.debug.assert(ty.hasRuntimeBitsIgnoreComptime()); + + var maybe_float_bits: ?u16 = null; + const max_byval_size = 512; + switch (ty.zigTypeTag()) { + .Struct => { + const bit_size = ty.bitSize(target); + if (ty.containerLayout() == .Packed) { + if (bit_size > 64) return .memory; + return .byval; + } + if (bit_size > max_byval_size) return .memory; + const float_count = countFloats(ty, target, &maybe_float_bits); + if (float_count <= byval_float_count) return .byval; + + const fields = ty.structFieldCount(); + var i: u32 = 0; + while (i < fields) : (i += 1) { + const field_ty = ty.structFieldType(i); + const field_alignment = ty.structFieldAlign(i, target); + const field_size = field_ty.bitSize(target); + if (field_size > 32 or field_alignment > 32) { + return Class.arrSize(bit_size, 64); + } + } + return Class.arrSize(bit_size, 32); + }, + .Union => { + const bit_size = ty.bitSize(target); + if (ty.containerLayout() == .Packed) { + if (bit_size > 64) return .memory; + return .byval; + } + if (bit_size > max_byval_size) return .memory; + const float_count = countFloats(ty, target, &maybe_float_bits); + if (float_count <= byval_float_count) return .byval; + + for (ty.unionFields().values()) |field| { + if (field.ty.bitSize(target) > 32 or field.normalAlignment(target) > 32) { + return Class.arrSize(bit_size, 64); + } + } + return Class.arrSize(bit_size, 32); + }, + .Bool, .Float => return .byval, + .Int => { + // TODO this is incorrect for _BitInt(128) but implementing + // this correctly makes implementing compiler-rt impossible. + // const bit_size = ty.bitSize(target); + // if (bit_size > 64) return .memory; + return .byval; + }, + .Enum, .ErrorSet => { + const bit_size = ty.bitSize(target); + if (bit_size > 64) return .memory; + return .byval; + }, + .Vector => { + const bit_size = ty.bitSize(target); + // TODO is this controlled by a cpu feature? + if (ctx == .ret and bit_size > 128) return .memory; + if (bit_size > 512) return .memory; + return .byval; + }, + .Optional => { + std.debug.assert(ty.isPtrLikeOptional()); + return .byval; + }, + .Pointer => { + std.debug.assert(!ty.isSlice()); + return .byval; + }, + .ErrorUnion, + .Frame, + .AnyFrame, + .NoReturn, + .Void, + .Type, + .ComptimeFloat, + .ComptimeInt, + .Undefined, + .Null, + .BoundFn, + .Fn, + .Opaque, + .EnumLiteral, + .Array, + => unreachable, + } +} + +const byval_float_count = 4; +fn countFloats(ty: Type, target: std.Target, maybe_float_bits: *?u16) u32 { + const invalid = std.math.maxInt(u32); + switch (ty.zigTypeTag()) { + .Union => { + const fields = ty.unionFields(); + var max_count: u32 = 0; + for (fields.values()) |field| { + const field_count = countFloats(field.ty, target, maybe_float_bits); + if (field_count == invalid) return invalid; + if (field_count > max_count) max_count = field_count; + if (max_count > byval_float_count) return invalid; + } + return max_count; + }, + .Struct => { + const fields_len = ty.structFieldCount(); + var count: u32 = 0; + var i: u32 = 0; + while (i < fields_len) : (i += 1) { + const field_ty = ty.structFieldType(i); + const field_count = countFloats(field_ty, target, maybe_float_bits); + if (field_count == invalid) return invalid; + count += field_count; + if (count > byval_float_count) return invalid; + } + return count; + }, + .Float => { + const float_bits = maybe_float_bits.* orelse { + const float_bits = ty.floatBits(target); + if (float_bits != 32 and float_bits != 64) return invalid; + maybe_float_bits.* = float_bits; + return 1; + }; + if (ty.floatBits(target) == float_bits) return 1; + return invalid; + }, + .Void => return 0, + else => return invalid, + } +} pub const callee_preserved_regs = [_]Register{ .r4, .r5, .r6, .r7, .r8, .r10 }; pub const caller_preserved_regs = [_]Register{ .r0, .r1, .r2, .r3 }; diff --git a/src/arch/riscv64/abi.zig b/src/arch/riscv64/abi.zig index 3792c4ab18..8a560f4596 100644 --- a/src/arch/riscv64/abi.zig +++ b/src/arch/riscv64/abi.zig @@ -2,6 +2,75 @@ const std = @import("std"); const bits = @import("bits.zig"); const Register = bits.Register; const RegisterManagerFn = @import("../../register_manager.zig").RegisterManager; +const Type = @import("../../type.zig").Type; + +pub const Class = enum { memory, byval, integer, double_integer }; + +pub fn classifyType(ty: Type, target: std.Target) Class { + std.debug.assert(ty.hasRuntimeBitsIgnoreComptime()); + + const max_byval_size = target.cpu.arch.ptrBitWidth() * 2; + switch (ty.zigTypeTag()) { + .Struct => { + const bit_size = ty.bitSize(target); + if (ty.containerLayout() == .Packed) { + if (bit_size > max_byval_size) return .memory; + return .byval; + } + // TODO this doesn't exactly match what clang produces but its better than nothing + if (bit_size > max_byval_size) return .memory; + if (bit_size > max_byval_size / 2) return .double_integer; + return .integer; + }, + .Union => { + const bit_size = ty.bitSize(target); + if (ty.containerLayout() == .Packed) { + if (bit_size > max_byval_size) return .memory; + return .byval; + } + // TODO this doesn't exactly match what clang produces but its better than nothing + if (bit_size > max_byval_size) return .memory; + if (bit_size > max_byval_size / 2) return .double_integer; + return .integer; + }, + .Bool => return .integer, + .Float => return .byval, + .Int, .Enum, .ErrorSet => { + const bit_size = ty.bitSize(target); + if (bit_size > max_byval_size) return .memory; + return .byval; + }, + .Vector => { + const bit_size = ty.bitSize(target); + if (bit_size > max_byval_size) return .memory; + return .integer; + }, + .Optional => { + std.debug.assert(ty.isPtrLikeOptional()); + return .byval; + }, + .Pointer => { + std.debug.assert(!ty.isSlice()); + return .byval; + }, + .ErrorUnion, + .Frame, + .AnyFrame, + .NoReturn, + .Void, + .Type, + .ComptimeFloat, + .ComptimeInt, + .Undefined, + .Null, + .BoundFn, + .Fn, + .Opaque, + .EnumLiteral, + .Array, + => unreachable, + } +} pub const callee_preserved_regs = [_]Register{ .s0, .s1, .s2, .s3, .s4, .s5, .s6, .s7, .s8, .s9, .s10, .s11, diff --git a/src/arch/x86_64/CodeGen.zig b/src/arch/x86_64/CodeGen.zig index a1b354482b..5f793aaeb9 100644 --- a/src/arch/x86_64/CodeGen.zig +++ b/src/arch/x86_64/CodeGen.zig @@ -7149,7 +7149,7 @@ fn resolveCallingConventionValues(self: *Self, fn_ty: Type) !CallMCValues { const classes: []const abi.Class = switch (self.target.os.tag) { .windows => &[1]abi.Class{abi.classifyWindows(ty, self.target.*)}, - else => mem.sliceTo(&abi.classifySystemV(ty, self.target.*), .none), + else => mem.sliceTo(&abi.classifySystemV(ty, self.target.*, .arg), .none), }; if (classes.len > 1) { return self.fail("TODO handle multiple classes per type", .{}); diff --git a/src/arch/x86_64/abi.zig b/src/arch/x86_64/abi.zig index 45c5760540..a428bcacdd 100644 --- a/src/arch/x86_64/abi.zig +++ b/src/arch/x86_64/abi.zig @@ -60,9 +60,11 @@ pub fn classifyWindows(ty: Type, target: Target) Class { } } +pub const Context = enum { ret, arg }; + /// There are a maximum of 8 possible return slots. Returned values are in /// the beginning of the array; unused slots are filled with .none. -pub fn classifySystemV(ty: Type, target: Target) [8]Class { +pub fn classifySystemV(ty: Type, target: Target, ctx: Context) [8]Class { const memory_class = [_]Class{ .memory, .none, .none, .none, .none, .none, .none, .none, @@ -134,6 +136,22 @@ pub fn classifySystemV(ty: Type, target: Target) [8]Class { }, .Vector => { const elem_ty = ty.childType(); + if (ctx == .arg) { + const bit_size = ty.bitSize(target); + if (bit_size > 128) return memory_class; + if (bit_size > 80) return .{ + .integer, .integer, .none, .none, + .none, .none, .none, .none, + }; + if (bit_size > 64) return .{ + .x87, .none, .none, .none, + .none, .none, .none, .none, + }; + return .{ + .integer, .none, .none, .none, + .none, .none, .none, .none, + }; + } const bits = elem_ty.bitSize(target) * ty.arrayLen(); if (bits <= 64) return .{ .sse, .none, .none, .none, @@ -201,7 +219,7 @@ pub fn classifySystemV(ty: Type, target: Target) [8]Class { } } const field_size = field.ty.abiSize(target); - const field_class_array = classifySystemV(field.ty, target); + const field_class_array = classifySystemV(field.ty, target, .arg); const field_class = std.mem.sliceTo(&field_class_array, .none); if (byte_i + field_size <= 8) { // Combine this field with the previous one. @@ -315,7 +333,7 @@ pub fn classifySystemV(ty: Type, target: Target) [8]Class { } } // Combine this field with the previous one. - const field_class = classifySystemV(field.ty, target); + const field_class = classifySystemV(field.ty, target, .arg); for (result) |*result_item, i| { const field_item = field_class[i]; // "If both classes are equal, this is the resulting class." |
