Sema: validate extern struct field types earlier

`validateExternType` does not require the type to be resolved so we can
check it earlier. Only doing it in `resolveTypeFully` lead to worse or
missing compile errors.

2 files changed, 5 insertions, 3 deletions

diff --git a/test/behavior/align.zig b/test/behavior/align.zig
index ad9a6d9616..d09e97c05b 100644
--- a/test/behavior/align.zig
+++ b/test/behavior/align.zig
@@ -299,7 +299,7 @@ test "implicitly decreasing fn alignment" {
     try testImplicitlyDecreaseFnAlign(alignedBig, 5678);
 }
 
-fn testImplicitlyDecreaseFnAlign(ptr: *align(1) const fn () i32, answer: i32) !void {
+fn testImplicitlyDecreaseFnAlign(ptr: *const fn () align(1) i32, answer: i32) !void {
     try expect(ptr() == answer);
 }
 
@@ -325,7 +325,7 @@ test "@alignCast functions" {
 fn fnExpectsOnly1(ptr: *const fn () align(1) i32) i32 {
     return fnExpects4(@alignCast(4, ptr));
 }
-fn fnExpects4(ptr: *align(4) const fn () i32) i32 {
+fn fnExpects4(ptr: *const fn () align(4) i32) i32 {
     return ptr();
 }
 fn simple4() align(4) i32 {
diff --git a/test/behavior/bugs/1310.zig b/test/behavior/bugs/1310.zig
index 1f19ec20c2..0f574942d3 100644
--- a/test/behavior/bugs/1310.zig
+++ b/test/behavior/bugs/1310.zig
@@ -4,7 +4,7 @@ const builtin = @import("builtin");
 
 pub const VM = ?[*]const struct_InvocationTable_;
 pub const struct_InvocationTable_ = extern struct {
-    GetVM: ?fn (?[*]VM) callconv(.C) c_int,
+    GetVM: ?*const fn (?[*]VM) callconv(.C) c_int,
 };
 
 pub const struct_VM_ = extern struct {
@@ -23,5 +23,7 @@ fn agent_callback(_vm: [*]VM, options: [*]u8) callconv(.C) i32 {
 }
 
 test "fixed" {
+    if (builtin.zig_backend == .stage1) return error.SkipZigTest;
+    if (builtin.zig_backend == .stage2_c) return error.SkipZigTest;
     try expect(agent_callback(undefined, undefined) == 11);
 }