aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLemonBoy <thatlemon@gmail.com>2020-01-18 19:24:04 +0100
committerLemonBoy <thatlemon@gmail.com>2020-01-18 19:24:04 +0100
commitf456b88baecc0a841520035973e6887eb2573319 (patch)
tree565f5b82714d3106da121a0a6c4181753b0fb575 /src
parent5f2bac010df0a2cf1e36622d6742baf13f4ffe75 (diff)
downloadzig-f456b88baecc0a841520035973e6887eb2573319.tar.gz
zig-f456b88baecc0a841520035973e6887eb2573319.zip
Get rid of some dead logic
Diffstat (limited to 'src')
-rw-r--r--src/ir.cpp25
1 files changed, 7 insertions, 18 deletions
diff --git a/src/ir.cpp b/src/ir.cpp
index 7f6a1963c5..42a5043279 100644
--- a/src/ir.cpp
+++ b/src/ir.cpp
@@ -6030,8 +6030,7 @@ static IrInstruction *ir_gen_builtin_fn_call(IrBuilder *irb, Scope *scope, AstNo
if (arg0_value == irb->codegen->invalid_instruction)
return arg0_value;
- IrInstruction *actual_tag = ir_build_union_tag(irb, scope, node, arg0_value);
- IrInstruction *tag_name = ir_build_tag_name(irb, scope, node, actual_tag);
+ IrInstruction *tag_name = ir_build_tag_name(irb, scope, node, arg0_value);
return ir_lval_wrap(irb, scope, tag_name, lval, result_loc);
}
case BuiltinFnIdTagType:
@@ -21389,10 +21388,6 @@ static IrInstruction *ir_analyze_union_tag(IrAnalyze *ira, IrInstruction *source
if (type_is_invalid(value->value->type))
return ira->codegen->invalid_instruction;
- if (value->value->type->id == ZigTypeIdEnum ||
- value->value->type->id == ZigTypeIdEnumLiteral)
- return value;
-
if (value->value->type->id != ZigTypeIdUnion) {
ir_add_error(ira, value,
buf_sprintf("expected enum or union type, found '%s'", buf_ptr(&value->value->type->name)));
@@ -21460,12 +21455,6 @@ static IrInstruction *ir_analyze_instruction_switch_br(IrAnalyze *ira,
if (type_is_invalid(case_value->value->type))
return ir_unreach_error(ira);
- if (case_value->value->type->id == ZigTypeIdEnum) {
- case_value = ir_analyze_union_tag(ira, &switch_br_instruction->base, case_value);
- if (type_is_invalid(case_value->value->type))
- return ir_unreach_error(ira);
- }
-
IrInstruction *casted_case_value = ir_implicit_cast(ira, case_value, target_value->value->type);
if (type_is_invalid(casted_case_value->value->type))
return ir_unreach_error(ira);
@@ -21510,12 +21499,6 @@ static IrInstruction *ir_analyze_instruction_switch_br(IrAnalyze *ira,
if (type_is_invalid(new_value->value->type))
continue;
- if (new_value->value->type->id == ZigTypeIdEnum) {
- new_value = ir_analyze_union_tag(ira, &switch_br_instruction->base, new_value);
- if (type_is_invalid(new_value->value->type))
- continue;
- }
-
IrInstruction *casted_new_value = ir_implicit_cast(ira, new_value, target_value->value->type);
if (type_is_invalid(casted_new_value->value->type))
continue;
@@ -22360,6 +22343,12 @@ static IrInstruction *ir_analyze_instruction_enum_tag_name(IrAnalyze *ira, IrIns
return result;
}
+ if (target->value->type->id == ZigTypeIdUnion) {
+ target = ir_analyze_union_tag(ira, &instruction->base, target);
+ if (type_is_invalid(target->value->type))
+ return ira->codegen->invalid_instruction;
+ }
+
assert(target->value->type->id == ZigTypeIdEnum);
if (instr_is_comptime(target)) {