diff options
| author | Cody Tapscott <topolarity@tapscott.me> | 2022-02-05 09:09:55 -0700 |
|---|---|---|
| committer | Andrew Kelley <andrew@ziglang.org> | 2022-02-06 22:21:46 -0700 |
| commit | c1cf158729f4d726639a5695754957f9f45f89da (patch) | |
| tree | c876a91ac6f02f3e7bdc9097c742cd609a3b6014 /src | |
| parent | 5065830aa007c374c382be9e80ba924df6cecc78 (diff) | |
| download | zig-c1cf158729f4d726639a5695754957f9f45f89da.tar.gz zig-c1cf158729f4d726639a5695754957f9f45f89da.zip | |
Replace argvCmd with std.mem.join
Diffstat (limited to 'src')
| -rw-r--r-- | src/main.zig | 27 |
1 files changed, 8 insertions, 19 deletions
diff --git a/src/main.zig b/src/main.zig index d6688081f1..6a1416cd6b 100644 --- a/src/main.zig +++ b/src/main.zig @@ -2881,7 +2881,7 @@ fn runOrTest( // execv releases the locks; no need to destroy the Compilation here. const err = std.process.execv(gpa, argv.items); try warnAboutForeignBinaries(gpa, arena, arg_mode, target_info, link_libc); - const cmd = try argvCmd(arena, argv.items); + const cmd = try std.mem.join(arena, " ", argv.items); fatal("the following command failed to execve with '{s}':\n{s}", .{ @errorName(err), cmd }); } else if (std.process.can_spawn) { const child = try std.ChildProcess.init(argv.items, gpa); @@ -2900,7 +2900,7 @@ fn runOrTest( const term = child.spawnAndWait() catch |err| { try warnAboutForeignBinaries(gpa, arena, arg_mode, target_info, link_libc); - const cmd = try argvCmd(arena, argv.items); + const cmd = try std.mem.join(arena, " ", argv.items); fatal("the following command failed with '{s}':\n{s}", .{ @errorName(err), cmd }); }; switch (arg_mode) { @@ -2931,12 +2931,12 @@ fn runOrTest( if (code == 0) { if (!watch) return cleanExit(); } else { - const cmd = try argvCmd(arena, argv.items); + const cmd = try std.mem.join(arena, " ", argv.items); fatal("the following test command failed with exit code {d}:\n{s}", .{ code, cmd }); } }, else => { - const cmd = try argvCmd(arena, argv.items); + const cmd = try std.mem.join(arena, " ", argv.items); fatal("the following test command crashed:\n{s}", .{cmd}); }, } @@ -2944,7 +2944,7 @@ fn runOrTest( else => unreachable, } } else { - const cmd = try argvCmd(arena, argv.items); + const cmd = try std.mem.join(arena, " ", argv.items); fatal("the following command cannot be executed ({s} does not support spawning a child process):\n{s}", .{ @tagName(builtin.os.tag), cmd }); } } @@ -3573,32 +3573,21 @@ pub fn cmdBuild(gpa: Allocator, arena: Allocator, args: []const []const u8) !voi if (prominent_compile_errors) { fatal("the build command failed with exit code {d}", .{code}); } else { - const cmd = try argvCmd(arena, child_argv); + const cmd = try std.mem.join(arena, " ", child_argv); fatal("the following build command failed with exit code {d}:\n{s}", .{ code, cmd }); } }, else => { - const cmd = try argvCmd(arena, child_argv); + const cmd = try std.mem.join(arena, " ", child_argv); fatal("the following build command crashed:\n{s}", .{cmd}); }, } } else { - const cmd = try argvCmd(arena, child_argv); + const cmd = try std.mem.join(arena, " ", child_argv); fatal("the following command cannot be executed ({s} does not support spawning a child process):\n{s}", .{ @tagName(builtin.os.tag), cmd }); } } -fn argvCmd(allocator: Allocator, argv: []const []const u8) ![]u8 { - var cmd = std.ArrayList(u8).init(allocator); - defer cmd.deinit(); - for (argv[0 .. argv.len - 1]) |arg| { - try cmd.appendSlice(arg); - try cmd.append(' '); - } - try cmd.appendSlice(argv[argv.len - 1]); - return cmd.toOwnedSlice(); -} - fn readSourceFileToEndAlloc( allocator: mem.Allocator, input: *const fs.File, |
