diff options
| author | Jakub Konka <kubkon@jakubkonka.com> | 2024-08-07 10:16:49 +0200 |
|---|---|---|
| committer | Jakub Konka <kubkon@jakubkonka.com> | 2024-08-07 10:21:03 +0200 |
| commit | b058545970efb6f533f9930d23af2a6d0c6ce9c3 (patch) | |
| tree | 08de418fbe5fc6ea8bfb86e6d03da17576606b17 /src | |
| parent | 90c4037819b44f285e78dafac5a0196abb36b86a (diff) | |
| download | zig-b058545970efb6f533f9930d23af2a6d0c6ce9c3.tar.gz zig-b058545970efb6f533f9930d23af2a6d0c6ce9c3.zip | |
elf: remove stale code
Diffstat (limited to 'src')
| -rw-r--r-- | src/link/Elf/Object.zig | 8 | ||||
| -rw-r--r-- | src/link/Elf/ZigObject.zig | 12 | ||||
| -rw-r--r-- | src/link/Elf/file.zig | 12 |
3 files changed, 0 insertions, 32 deletions
diff --git a/src/link/Elf/Object.zig b/src/link/Elf/Object.zig index a81a6f34f3..a6f9c4ac18 100644 --- a/src/link/Elf/Object.zig +++ b/src/link/Elf/Object.zig @@ -630,12 +630,6 @@ pub fn claimUnresolvedObject(self: *Object, elf_file: *Elf) void { if (esym.st_shndx != elf.SHN_UNDEF) continue; if (elf_file.symbol(self.resolveSymbol(esym_index, elf_file)) != null) continue; - // TODO: audit this - // const global = elf_file.symbol(index); - // if (global.file(elf_file)) |file| { - // if (global.elfSym(elf_file).st_shndx != elf.SHN_UNDEF or file.index() <= self.index) continue; - // } - sym.value = 0; sym.ref = .{ .index = 0, .file = 0 }; sym.esym_index = esym_index; @@ -849,8 +843,6 @@ pub fn resolveMergeSubsections(self: *Object, elf_file: *Elf) !void { for (self.symtab.items, 0..) |*esym, idx| { const sym = &self.symbols.items[idx]; - // TODO: do we need ref here? - if (esym.st_shndx == elf.SHN_COMMON or esym.st_shndx == elf.SHN_UNDEF or esym.st_shndx == elf.SHN_ABS) continue; const imsec_index = self.input_merge_sections_indexes.items[esym.st_shndx]; diff --git a/src/link/Elf/ZigObject.zig b/src/link/Elf/ZigObject.zig index 46c249d29f..e01c820f89 100644 --- a/src/link/Elf/ZigObject.zig +++ b/src/link/Elf/ZigObject.zig @@ -410,12 +410,6 @@ pub fn claimUnresolvedObject(self: ZigObject, elf_file: *Elf) void { if (esym.st_shndx != elf.SHN_UNDEF) continue; if (elf_file.symbol(self.resolveSymbol(@intCast(i | global_symbol_bit), elf_file)) != null) continue; - // TODO: audit this - // const global = elf_file.symbol(index); - // if (global.file(elf_file)) |file| { - // if (global.elfSym(elf_file).st_shndx != elf.SHN_UNDEF or file.index() <= self.index) continue; - // } - global.value = 0; global.ref = .{ .index = 0, .file = 0 }; global.esym_index = @intCast(index); @@ -1512,12 +1506,6 @@ pub fn deleteExport( log.debug("deleting export '{s}'", .{exp_name}); const esym = &self.symtab.items(.elf_sym)[esym_index.*]; _ = self.globals_lookup.remove(esym.st_name); - // const sym_index = elf_file.resolver.get(esym.st_name).?; - // const sym = elf_file.symbol(sym_index); - // if (sym.file_index == self.index) { - // _ = elf_file.resolver.swapRemove(esym.st_name); - // sym.* = .{}; - // } esym.* = Elf.null_sym; self.symtab.items(.shndx)[esym_index.*] = elf.SHN_UNDEF; } diff --git a/src/link/Elf/file.zig b/src/link/Elf/file.zig index 2c3b953523..88dc807274 100644 --- a/src/link/Elf/file.zig +++ b/src/link/Elf/file.zig @@ -67,18 +67,6 @@ pub const File = union(enum) { }; } - pub fn resetGlobals(file: File, elf_file: *Elf) void { - for (file.globals()) |global_index| { - const global = elf_file.symbol(global_index); - const name_offset = global.name_offset; - const extra_index = global.extra_index; - global.* = .{}; - global.name_offset = name_offset; - global.flags.global = true; - global.extra_index = extra_index; - } - } - pub fn setAlive(file: File) void { switch (file) { .zig_object, .linker_defined => {}, |
