diff options
| author | Andrew Kelley <andrew@ziglang.org> | 2023-06-12 19:09:30 -0700 |
|---|---|---|
| committer | Andrew Kelley <andrew@ziglang.org> | 2023-06-12 19:09:30 -0700 |
| commit | 2ad073ec6d4e2be967f18c9907844404a7eed42e (patch) | |
| tree | 56c925bd7df84e5f223c31a7c8fa90606c8e2dc9 /src | |
| parent | 4b7c1e5c300c471618c9b12646247ef887a3a576 (diff) | |
| download | zig-2ad073ec6d4e2be967f18c9907844404a7eed42e.tar.gz zig-2ad073ec6d4e2be967f18c9907844404a7eed42e.zip | |
link/Plan9: fix UAF of symbol names
Long term, linker backends will need to manage their own string tables
for things like this because my mandate is: no long-lived pointers
allowed in any of the codepaths touched by incremental compilation, so
that we can serialize and deserialize trivially.
Short term, I solved this with a couple calls to Allocator.dupe,
incurring some harmless leaks.
Diffstat (limited to 'src')
| -rw-r--r-- | src/link/Plan9.zig | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/link/Plan9.zig b/src/link/Plan9.zig index 2606dd7aac..c08754b57a 100644 --- a/src/link/Plan9.zig +++ b/src/link/Plan9.zig @@ -441,7 +441,7 @@ fn updateFinish(self: *Plan9, decl_index: Module.Decl.Index) !void { const sym: aout.Sym = .{ .value = undefined, // the value of stuff gets filled in in flushModule .type = decl_block.type, - .name = mod.intern_pool.stringToSlice(decl.name), + .name = try self.base.allocator.dupe(u8, mod.intern_pool.stringToSlice(decl.name)), }; if (decl_block.sym_index) |s| { @@ -741,7 +741,7 @@ fn addDeclExports( const sym = .{ .value = decl_block.offset.?, .type = decl_block.type.toGlobal(), - .name = exp_name, + .name = try self.base.allocator.dupe(u8, exp_name), }; if (metadata.getExport(self, exp_name)) |i| { |