diff options
| author | Jakub Konka <kubkon@jakubkonka.com> | 2022-11-07 15:17:34 +0100 |
|---|---|---|
| committer | Jakub Konka <kubkon@jakubkonka.com> | 2022-11-08 13:42:58 +0100 |
| commit | 0d556877af4d12e1e0d5c0146ab80273e91f211c (patch) | |
| tree | ab7c9e6cffef99d9d705dc9d6ffda9ba3761cb48 /src | |
| parent | a07449450f460dacd3ad4daa480e00c7bc9e9d7f (diff) | |
| download | zig-0d556877af4d12e1e0d5c0146ab80273e91f211c.tar.gz zig-0d556877af4d12e1e0d5c0146ab80273e91f211c.zip | |
aarch64: implement .wrap_optional always saving to the stack
Diffstat (limited to 'src')
| -rw-r--r-- | src/arch/aarch64/CodeGen.zig | 32 |
1 files changed, 28 insertions, 4 deletions
diff --git a/src/arch/aarch64/CodeGen.zig b/src/arch/aarch64/CodeGen.zig index 29a01ae8b8..5adf81148b 100644 --- a/src/arch/aarch64/CodeGen.zig +++ b/src/arch/aarch64/CodeGen.zig @@ -3068,13 +3068,37 @@ fn airSaveErrReturnTraceIndex(self: *Self, inst: Air.Inst.Index) !void { fn airWrapOptional(self: *Self, inst: Air.Inst.Index) !void { const ty_op = self.air.instructions.items(.data)[inst].ty_op; const result: MCValue = if (self.liveness.isUnused(inst)) .dead else result: { + const payload_ty = self.air.typeOf(ty_op.operand); + if (!payload_ty.hasRuntimeBits()) { + break :result MCValue{ .immediate = 1 }; + } + const optional_ty = self.air.typeOfIndex(inst); + const operand = try self.resolveInst(ty_op.operand); + const operand_lock: ?RegisterLock = switch (operand) { + .register => |reg| self.register_manager.lockRegAssumeUnused(reg), + else => null, + }; + defer if (operand_lock) |lock| self.register_manager.unlockReg(lock); - // Optional with a zero-bit payload type is just a boolean true - if (optional_ty.abiSize(self.target.*) == 1) - break :result MCValue{ .immediate = 1 }; + if (optional_ty.isPtrLikeOptional()) { + // TODO should we check if we can reuse the operand? + const raw_reg = try self.register_manager.allocReg(inst, gp); + const reg = self.registerAlias(raw_reg, payload_ty); + try self.genSetReg(payload_ty, raw_reg, operand); + break :result MCValue{ .register = reg }; + } - return self.fail("TODO implement wrap optional for {}", .{self.target.cpu.arch}); + const optional_abi_size = @intCast(u32, optional_ty.abiSize(self.target.*)); + const optional_abi_align = optional_ty.abiAlignment(self.target.*); + const payload_abi_size = @intCast(u32, payload_ty.abiSize(self.target.*)); + const offset = optional_abi_size - payload_abi_size; + + const stack_offset = try self.allocMem(optional_abi_size, optional_abi_align, inst); + try self.genSetStack(Type.bool, stack_offset, .{ .immediate = 1 }); + try self.genSetStack(payload_ty, stack_offset - @intCast(u32, offset), operand); + + break :result MCValue{ .stack_offset = stack_offset }; }; return self.finishAir(inst, result, .{ ty_op.operand, .none, .none }); } |
