Merge pull request #18017 from mlugg/var-never-mutated

compiler: add error for unnecessary use of 'var'

1 files changed, 6 insertions, 6 deletions

diff --git a/src/resinator/parse.zig b/src/resinator/parse.zig
index 2e528bea65..68537b94f6 100644
--- a/src/resinator/parse.zig
+++ b/src/resinator/parse.zig
@@ -100,7 +100,7 @@ pub const Parser = struct {
             // because it almost always leads to unhelpful error messages
             // (usually it will end up with bogus things like 'file
             // not found: {')
-            var statement = try self.parseStatement();
+            const statement = try self.parseStatement();
             try statements.append(statement);
         }
     }
@@ -698,7 +698,7 @@ pub const Parser = struct {
             .dlginclude => {
                 const common_resource_attributes = try self.parseCommonResourceAttributes();
 
-                var filename_expression = try self.parseExpression(.{
+                const filename_expression = try self.parseExpression(.{
                     .allowed_types = .{ .string = true },
                 });
 
@@ -756,7 +756,7 @@ pub const Parser = struct {
                     return &node.base;
                 }
 
-                var filename_expression = try self.parseExpression(.{
+                const filename_expression = try self.parseExpression(.{
                     // Don't tell the user that numbers are accepted since we error on
                     // number expressions and regular number literals are treated as unquoted
                     // literals rather than numbers, so from the users perspective
@@ -934,8 +934,8 @@ pub const Parser = struct {
             style = try optional_param_parser.parse(.{ .not_expression_allowed = true });
         }
 
-        var exstyle: ?*Node = try optional_param_parser.parse(.{ .not_expression_allowed = true });
-        var help_id: ?*Node = switch (resource) {
+        const exstyle: ?*Node = try optional_param_parser.parse(.{ .not_expression_allowed = true });
+        const help_id: ?*Node = switch (resource) {
             .dialogex => try optional_param_parser.parse(.{}),
             else => null,
         };
@@ -1526,7 +1526,7 @@ pub const Parser = struct {
 
         pub fn toErrorDetails(options: ParseExpressionOptions, token: Token) ErrorDetails {
             // TODO: expected_types_override interaction with is_known_to_be_number_expression?
-            var expected_types = options.expected_types_override orelse ErrorDetails.ExpectedTypes{
+            const expected_types = options.expected_types_override orelse ErrorDetails.ExpectedTypes{
                 .number = options.allowed_types.number,
                 .number_expression = options.allowed_types.number,
                 .string_literal = options.allowed_types.string and !options.is_known_to_be_number_expression,