aboutsummaryrefslogtreecommitdiff
path: root/src/link
diff options
context:
space:
mode:
authorAndrew Kelley <andrew@ziglang.org>2020-12-28 11:24:53 -0700
committerAndrew Kelley <andrew@ziglang.org>2020-12-28 11:24:53 -0700
commitf75d4cbe56f9f8212581f00700600a57ce545ba1 (patch)
tree9061ca185cd38119116333c4fee9f5d26a0619dc /src/link
parent7ed499ec4549fa7304b822446b23cff993b8fa6f (diff)
downloadzig-f75d4cbe56f9f8212581f00700600a57ce545ba1.tar.gz
zig-f75d4cbe56f9f8212581f00700600a57ce545ba1.zip
Revert "stage2: add compile log statement (#7191)"
The addition of `addDeclErr` introduced a memory leak at every call site, and I also would like to push back on having more than 1 compilation error per `Decl`. This reverts commit 1634d45f1d53c8d7bfefa56ab4d2fa4cc8218b6d.
Diffstat (limited to 'src/link')
-rw-r--r--src/link/C.zig2
-rw-r--r--src/link/Coff.zig2
-rw-r--r--src/link/Elf.zig2
-rw-r--r--src/link/MachO.zig2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/link/C.zig b/src/link/C.zig
index cadbcf105f..325f2ee048 100644
--- a/src/link/C.zig
+++ b/src/link/C.zig
@@ -106,7 +106,7 @@ pub fn deinit(self: *C) void {
pub fn updateDecl(self: *C, module: *Module, decl: *Module.Decl) !void {
codegen.generate(self, decl) catch |err| {
if (err == error.AnalysisFail) {
- try module.addDeclErr(decl, self.error_msg);
+ try module.failed_decls.put(module.gpa, decl, self.error_msg);
}
return err;
};
diff --git a/src/link/Coff.zig b/src/link/Coff.zig
index 5ec4284623..bea3033f88 100644
--- a/src/link/Coff.zig
+++ b/src/link/Coff.zig
@@ -658,7 +658,7 @@ pub fn updateDecl(self: *Coff, module: *Module, decl: *Module.Decl) !void {
.appended => code_buffer.items,
.fail => |em| {
decl.analysis = .codegen_failure;
- try module.addDeclErr(decl, em);
+ try module.failed_decls.put(module.gpa, decl, em);
return;
},
};
diff --git a/src/link/Elf.zig b/src/link/Elf.zig
index 2cd668c09f..6232a64e4a 100644
--- a/src/link/Elf.zig
+++ b/src/link/Elf.zig
@@ -2248,7 +2248,7 @@ pub fn updateDecl(self: *Elf, module: *Module, decl: *Module.Decl) !void {
.appended => code_buffer.items,
.fail => |em| {
decl.analysis = .codegen_failure;
- try module.addDeclErr(decl, em);
+ try module.failed_decls.put(module.gpa, decl, em);
return;
},
};
diff --git a/src/link/MachO.zig b/src/link/MachO.zig
index 8c3001938f..17816959a3 100644
--- a/src/link/MachO.zig
+++ b/src/link/MachO.zig
@@ -1062,7 +1062,7 @@ pub fn updateDecl(self: *MachO, module: *Module, decl: *Module.Decl) !void {
.appended => code_buffer.items,
.fail => |em| {
decl.analysis = .codegen_failure;
- try module.addDeclErr(decl, em);
+ try module.failed_decls.put(module.gpa, decl, em);
return;
},
};