aboutsummaryrefslogtreecommitdiff
path: root/src/link
diff options
context:
space:
mode:
authorJakub Konka <kubkon@jakubkonka.com>2022-08-03 21:26:52 +0200
committerJakub Konka <kubkon@jakubkonka.com>2022-08-03 21:26:52 +0200
commit007eb3bd714caee550722cae0e4e98a205ead341 (patch)
tree1e842d026f9fdc02acaa0d99aeddb0a1a9743303 /src/link
parent2c8fc3b5979d6ca8befbf5de48a661a6fadbe819 (diff)
downloadzig-007eb3bd714caee550722cae0e4e98a205ead341.tar.gz
zig-007eb3bd714caee550722cae0e4e98a205ead341.zip
macho: fix some TODOs
Diffstat (limited to 'src/link')
-rw-r--r--src/link/MachO.zig9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/link/MachO.zig b/src/link/MachO.zig
index a955200a77..db207af5f5 100644
--- a/src/link/MachO.zig
+++ b/src/link/MachO.zig
@@ -64,7 +64,10 @@ const SystemLib = struct {
const Section = struct {
header: macho.section_64,
segment_index: u8,
- last_atom: ?*Atom = null, // TODO temporary hack; we really should shrink section to 0
+
+ // TODO is null here necessary, or can we do away with tracking via section
+ // size in incremental context?
+ last_atom: ?*Atom = null,
/// A list of atoms that have surplus capacity. This list can have false
/// positives, as functions grow and shrink over time, only sometimes being added
@@ -4434,8 +4437,8 @@ fn initSection(
}
header.addr = seg.vmaddr + off - seg.fileoff;
- // TODO this will break if we are inserting section that is not the last section
- // in a segment.
+ // TODO Will this break if we are inserting section that is not the last section
+ // in a segment?
const max_size = self.allocatedSize(segment_id, off);
if (size > max_size) {