aboutsummaryrefslogtreecommitdiff
path: root/src/link/Elf.zig
diff options
context:
space:
mode:
authorAndrew Kelley <andrew@ziglang.org>2024-12-03 14:04:59 -0800
committerAndrew Kelley <andrew@ziglang.org>2025-01-15 15:11:35 -0800
commit6235cc3da4d2c6ebf7fd31242e8d82d39f5c81cf (patch)
tree619bd40a601c199b19bbac7ba25fff93fac4d1d5 /src/link/Elf.zig
parent16180f525a966de10b6fc0822fea107baf1f24f6 (diff)
downloadzig-6235cc3da4d2c6ebf7fd31242e8d82d39f5c81cf.tar.gz
zig-6235cc3da4d2c6ebf7fd31242e8d82d39f5c81cf.zip
remove "FIXME" from codebase
See #363. Please file issues rather than making TODO comments.
Diffstat (limited to 'src/link/Elf.zig')
-rw-r--r--src/link/Elf.zig7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/link/Elf.zig b/src/link/Elf.zig
index 086fa89e7c..543cd80f6a 100644
--- a/src/link/Elf.zig
+++ b/src/link/Elf.zig
@@ -3127,9 +3127,6 @@ pub fn sortShdrs(
fileLookup(files, ref.file, zig_object_ptr).?.atom(ref.index).?.output_section_index = atom_list.output_section_index;
}
if (shdr.sh_type == elf.SHT_RELA) {
- // FIXME:JK we should spin up .symtab potentially earlier, or set all non-dynamic RELA sections
- // to point at symtab
- // shdr.sh_link = backlinks[shdr.sh_link];
shdr.sh_link = section_indexes.symtab.?;
shdr.sh_info = backlinks[shdr.sh_info];
}
@@ -3217,7 +3214,7 @@ fn updateSectionSizes(self: *Elf) !void {
atom_list.dirty = false;
}
- // FIXME:JK this will hopefully not be needed once we create a link from Atom/Thunk to AtomList.
+ // This might not be needed if there was a link from Atom/Thunk to AtomList.
for (self.thunks.items) |*th| {
th.value += slice.items(.atom_list_2)[th.output_section_index].value;
}
@@ -3303,7 +3300,6 @@ fn updateSectionSizes(self: *Elf) !void {
self.updateShStrtabSize();
}
-// FIXME:JK this is very much obsolete, remove!
pub fn updateShStrtabSize(self: *Elf) void {
if (self.section_indexes.shstrtab) |index| {
self.sections.items(.shdr)[index].sh_size = self.shstrtab.items.len;
@@ -3914,7 +3910,6 @@ fn writeSyntheticSections(self: *Elf) !void {
try self.writeShStrtab();
}
-// FIXME:JK again, why is this needed?
pub fn writeShStrtab(self: *Elf) !void {
if (self.section_indexes.shstrtab) |index| {
const shdr = self.sections.items(.shdr)[index];