diff options
| author | Andrew Kelley <andrew@ziglang.org> | 2023-03-16 21:51:58 -0700 |
|---|---|---|
| committer | Andrew Kelley <andrew@ziglang.org> | 2023-03-16 21:51:58 -0700 |
| commit | 4d7e77cb1701a45e174a015d4803e01e12179b06 (patch) | |
| tree | 677e5c5c67217e398501820dd26351e67d48df04 /src/codegen/llvm/bindings.zig | |
| parent | 1ed569e0b23c4432cd00604dcae89a17edc852a9 (diff) | |
| download | zig-4d7e77cb1701a45e174a015d4803e01e12179b06.tar.gz zig-4d7e77cb1701a45e174a015d4803e01e12179b06.zip | |
remove standalone test "issue_9812"
This test has a few problems:
* I don't want to vendor third party projects into the main compiler
repository such as kuba-zip just for test cases. If we want to test
third party projects, that should be a separate repository dedicated
to that purpose.
* Ideally tests would be isolated to test a particular thing, rather
than have a lot of unrelated logic that is not what is primarily
being tested.
* Ideally tests will not be named after GitHub issues, but named after
the thing that is being tested. And not testing for the absence of a
bug, but for the existence of correct behavior.
Aside from these issues, it's also failing in the LLVM 16 branch:
```
kuba-zip/zip.c:276:16: error: call to undeclared function 'fileno'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
kuba-zip/zip.c:277:14: error: call to undeclared function 'ftruncate'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
kuba-zip/zip.c:364:11: error: call to undeclared function 'symlink'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
```
These are not interesting failures related to the thing actually being
tested; this is busywork related to the fact that we vendor third party
code. So, that is why I chose to delete this test case instead of repair
it.
Diffstat (limited to 'src/codegen/llvm/bindings.zig')
0 files changed, 0 insertions, 0 deletions
