diff options
| author | Andrew Kelley <andrew@ziglang.org> | 2022-07-14 21:22:01 -0700 |
|---|---|---|
| committer | Andrew Kelley <andrew@ziglang.org> | 2022-07-14 22:26:11 -0700 |
| commit | 8c14d170b579e078ff961973e4d28a4946df36d7 (patch) | |
| tree | 63d2c4d8eaeaa1ae08eac8438d26982f25ddf4b1 /src/codegen/llvm.zig | |
| parent | 9c136be78fcc44d4dd4902605de6af14358c67a3 (diff) | |
| download | zig-8c14d170b579e078ff961973e4d28a4946df36d7.tar.gz zig-8c14d170b579e078ff961973e4d28a4946df36d7.zip | |
Revert "stage2 llvm: Use unpacked struct for unions and arrays"
This reverts commit 2eaef84ebe968224b0cf25206abf12ea1c5e0f5a.
Here is a motivating example:
```zig
const E = union(enum) {
A: [9]u8,
B: u64,
};
```
```llvm
%test2.E = type { { i64, [1 x i8] }, i1, [6 x i8] }
```
```
error(codegen): when lowering test2.E, Zig ABI size = 16 but LLVM ABI size = 24
```
Diffstat (limited to 'src/codegen/llvm.zig')
| -rw-r--r-- | src/codegen/llvm.zig | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/codegen/llvm.zig b/src/codegen/llvm.zig index fd26a603dd..d7bdbd1062 100644 --- a/src/codegen/llvm.zig +++ b/src/codegen/llvm.zig @@ -2734,7 +2734,7 @@ pub const DeclGen = struct { llvm_aligned_field_ty, dg.context.intType(8).arrayType(padding_len), }; - break :t dg.context.structType(&fields, fields.len, .False); + break :t dg.context.structType(&fields, fields.len, .True); }; if (layout.tag_size == 0) { @@ -3050,7 +3050,7 @@ pub const DeclGen = struct { return dg.context.constStruct( llvm_elems.ptr, @intCast(c_uint, llvm_elems.len), - .False, + .True, ); } else { const llvm_elem_ty = try dg.lowerType(elem_ty); @@ -3087,7 +3087,7 @@ pub const DeclGen = struct { return dg.context.constStruct( llvm_elems.ptr, @intCast(c_uint, llvm_elems.len), - .False, + .True, ); } else { const llvm_elem_ty = try dg.lowerType(elem_ty); @@ -3104,7 +3104,7 @@ pub const DeclGen = struct { const llvm_elems: [1]*const llvm.Value = .{sentinel}; const need_unnamed = dg.isUnnamedType(elem_ty, llvm_elems[0]); if (need_unnamed) { - return dg.context.constStruct(&llvm_elems, llvm_elems.len, .False); + return dg.context.constStruct(&llvm_elems, llvm_elems.len, .True); } else { const llvm_elem_ty = try dg.lowerType(elem_ty); return llvm_elem_ty.constArray(&llvm_elems, llvm_elems.len); @@ -3397,7 +3397,7 @@ pub const DeclGen = struct { const fields: [2]*const llvm.Value = .{ field, dg.context.intType(8).arrayType(padding_len).getUndef(), }; - break :p dg.context.constStruct(&fields, fields.len, .False); + break :p dg.context.constStruct(&fields, fields.len, .True); }; if (layout.tag_size == 0) { |