Sema: fix unreasonable progress node numbers

The "completed" count in the "Semantic Analysis" progress node had
regressed since 0.14.0: the number got crazy big very fast, even on
simple cases. For instance, an empty `pub fn main` got to ~59,000 where
on 0.14 it only reached ~4,000. This was happening because I was
unintentionally introducing a node every time type resolution was
*requested*, even if (as is usually the case) it turned out to already
be done. The fix is simply to start the progress node a little later,
once we know we are actually doing semantic analysis. This brings the
number for that empty test case down to ~5,000, which makes perfect
sense. It won't exactly match 0.14, because the standard library has
changed, and also because the compiler's progress output does have some
*intentional* changes.

1 files changed, 0 insertions, 6 deletions

diff --git a/src/Type.zig b/src/Type.zig
index 0677b8d227..9316bec11e 100644
--- a/src/Type.zig
+++ b/src/Type.zig
@@ -3797,9 +3797,6 @@ fn resolveStructInner(
         return error.AnalysisFail;
     }
 
-    const tracked_unit = zcu.trackUnitSema(struct_obj.name.toSlice(&zcu.intern_pool), null);
-    defer tracked_unit.end(zcu);
-
     if (zcu.comp.debugIncremental()) {
         const info = try zcu.incremental_debug_state.getUnitInfo(gpa, owner);
         info.last_update_gen = zcu.generation;
@@ -3859,9 +3856,6 @@ fn resolveUnionInner(
         return error.AnalysisFail;
     }
 
-    const tracked_unit = zcu.trackUnitSema(union_obj.name.toSlice(&zcu.intern_pool), null);
-    defer tracked_unit.end(zcu);
-
     if (zcu.comp.debugIncremental()) {
         const info = try zcu.incremental_debug_state.getUnitInfo(gpa, owner);
         info.last_update_gen = zcu.generation;