diff options
| author | dweiller <4678790+dweiller@users.noreply.github.com> | 2024-01-15 15:33:41 +1100 |
|---|---|---|
| committer | dweiller <4678790+dweiller@users.noreply.github.com> | 2024-01-15 20:55:01 +1100 |
| commit | 1861423862194e845c631d0e0eea5c7bca5d284b (patch) | |
| tree | fe1544d7b60c21217dfd4ae7cd299270f7aefb66 /src/Sema.zig | |
| parent | 9097bcc06e8d9c4691fac18f7a6b4d7f2d63eefe (diff) | |
| download | zig-1861423862194e845c631d0e0eea5c7bca5d284b.tar.gz zig-1861423862194e845c631d0e0eea5c7bca5d284b.zip | |
sema: fix OOM bug when constructing error messages
Diffstat (limited to 'src/Sema.zig')
| -rw-r--r-- | src/Sema.zig | 58 |
1 files changed, 33 insertions, 25 deletions
diff --git a/src/Sema.zig b/src/Sema.zig index 99564fd1ea..2e203ee20b 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -28657,7 +28657,7 @@ fn coerceExtra( if (!dest_info.flags.is_const) { const err_msg = err_msg: { const err_msg = try sema.errMsg(block, inst_src, "cannot cast pointer to tuple to '{}'", .{dest_ty.fmt(mod)}); - errdefer err_msg.deinit(sema.gpa); + errdefer err_msg.destroy(sema.gpa); try sema.errNote(block, dest_ty_src, err_msg, "pointers to tuples can only coerce to constant pointers", .{}); break :err_msg err_msg; }; @@ -32599,31 +32599,39 @@ fn analyzeSlice( if (try sema.compareScalar(start_value, .neq, end_value, Type.comptime_int)) { if (try sema.compareScalar(start_value, .neq, Value.zero_comptime_int, Type.comptime_int)) { - const err_msg = try sema.errMsg(block, start_src, bounds_error_message, .{}); - try sema.errNote( - block, - start_src, - err_msg, - "expected '{}', found '{}'", - .{ - Value.zero_comptime_int.fmtValue(Type.comptime_int, mod), - start_value.fmtValue(Type.comptime_int, mod), - }, - ); - return sema.failWithOwnedErrorMsg(block, err_msg); + const msg = msg: { + const msg = try sema.errMsg(block, start_src, bounds_error_message, .{}); + errdefer msg.destroy(sema.gpa); + try sema.errNote( + block, + start_src, + msg, + "expected '{}', found '{}'", + .{ + Value.zero_comptime_int.fmtValue(Type.comptime_int, mod), + start_value.fmtValue(Type.comptime_int, mod), + }, + ); + break :msg msg; + }; + return sema.failWithOwnedErrorMsg(block, msg); } else if (try sema.compareScalar(end_value, .neq, Value.one_comptime_int, Type.comptime_int)) { - const err_msg = try sema.errMsg(block, end_src, bounds_error_message, .{}); - try sema.errNote( - block, - end_src, - err_msg, - "expected '{}', found '{}'", - .{ - Value.one_comptime_int.fmtValue(Type.comptime_int, mod), - end_value.fmtValue(Type.comptime_int, mod), - }, - ); - return sema.failWithOwnedErrorMsg(block, err_msg); + const msg = msg: { + const msg = try sema.errMsg(block, end_src, bounds_error_message, .{}); + errdefer msg.destroy(sema.gpa); + try sema.errNote( + block, + end_src, + msg, + "expected '{}', found '{}'", + .{ + Value.one_comptime_int.fmtValue(Type.comptime_int, mod), + end_value.fmtValue(Type.comptime_int, mod), + }, + ); + break :msg msg; + }; + return sema.failWithOwnedErrorMsg(block, msg); } } else { if (try sema.compareScalar(end_value, .gt, Value.one_comptime_int, Type.comptime_int)) { |