diff options
| author | Veikka Tuominen <git@vexu.eu> | 2023-01-05 13:25:36 +0200 |
|---|---|---|
| committer | Veikka Tuominen <git@vexu.eu> | 2023-01-05 14:26:53 +0200 |
| commit | 0ecec5fcca3ae8f33bf307c2ca66b8d11baf3d1d (patch) | |
| tree | c3b09089496106831a25e7597a0b59607e95c458 /src/Sema.zig | |
| parent | 352c71873b1c018fed8821d275b490be8c881792 (diff) | |
| download | zig-0ecec5fcca3ae8f33bf307c2ca66b8d11baf3d1d.tar.gz zig-0ecec5fcca3ae8f33bf307c2ca66b8d11baf3d1d.zip | |
resolve some TODOs
Diffstat (limited to 'src/Sema.zig')
| -rw-r--r-- | src/Sema.zig | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/Sema.zig b/src/Sema.zig index d73411e7b7..2cbdb615f6 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -3319,8 +3319,6 @@ fn zirEnsureErrUnionPayloadVoid(sema: *Sema, block: *Block, inst: Zir.Inst.Index operand_ty.childType() else operand_ty; - // TODO this should be validated in a more generic instruction that is - // emitted for all ifs and whiles with an error union condition. if (err_union_ty.zigTypeTag() != .ErrorUnion) return; const payload_ty = err_union_ty.errorUnionPayload().zigTypeTag(); if (payload_ty != .Void and payload_ty != .NoReturn) { @@ -21596,7 +21594,7 @@ fn zirVarExtended( .owner_decl = sema.owner_decl_index, .init = init_val, .is_extern = small.is_extern, - .is_mutable = true, // TODO get rid of this unused field + .is_mutable = true, .is_threadlocal = small.is_threadlocal, .is_weak_linkage = false, .lib_name = null, @@ -22075,7 +22073,7 @@ fn zirBuiltinExtern( .owner_decl = sema.owner_decl_index, .init = Value.initTag(.unreachable_value), .is_extern = true, - .is_mutable = false, // TODO get rid of this unused field + .is_mutable = false, .is_threadlocal = options.is_thread_local, .is_weak_linkage = options.linkage == .Weak, .lib_name = null, |