aboutsummaryrefslogtreecommitdiff
path: root/src/Compilation.zig
diff options
context:
space:
mode:
authorJakub Konka <kubkon@jakubkonka.com>2021-06-07 18:00:36 +0200
committerJakub Konka <kubkon@jakubkonka.com>2021-06-08 05:48:33 +0200
commitb0ee911c2389e507d36a2f9c2442046133c18b93 (patch)
tree6eabd7a69ee1acffec6b2765b41026a9816bd40e /src/Compilation.zig
parent7462b0e5b9d03ed6704c83f444b083a973278da5 (diff)
downloadzig-b0ee911c2389e507d36a2f9c2442046133c18b93.tar.gz
zig-b0ee911c2389e507d36a2f9c2442046133c18b93.zip
wasi: always grant fd_readdir right
Since v0.23 release of Wasmtime, if we want to iterate a directory Y then directory Y needed to have been granted `fd_readdir` right. However, it is now also required for directory X to carry `fd_readdir` right, and so on, up-chain all the way until we reach the preopen (which possesses all rights by default). This caused problems for us since our libstd implementation is more fine-grained and allowed for parent dirs not to carry the right while allow for iterating on its children. My proposal here is to always grant `fd_readdir` right as part of `std.fs.Dir.OpenDirOptions.access_sub_paths`. This seems to be the approach taken by Rust also, plus we should be justified to take this approach since WASI is experimental and snapshot1 will be discontinued eventually and replaced with a new approach to access management that will require a complete rewrite of our libstd anyhow.
Diffstat (limited to 'src/Compilation.zig')
0 files changed, 0 insertions, 0 deletions