diff options
| author | Andrew Kelley <andrew@ziglang.org> | 2021-04-22 18:07:46 -0700 |
|---|---|---|
| committer | Andrew Kelley <andrew@ziglang.org> | 2021-04-22 18:07:46 -0700 |
| commit | 507a8096d2f9624bafaf963c3e189a477ef6b7bf (patch) | |
| tree | c21e3d54e1389fe44ecc7d5f230e792e26ab322d /src/AstGen.zig | |
| parent | 7c453b91b85bab6800d24feb57c4f35b8ce48d57 (diff) | |
| download | zig-507a8096d2f9624bafaf963c3e189a477ef6b7bf.tar.gz zig-507a8096d2f9624bafaf963c3e189a477ef6b7bf.zip | |
std: fix compile errors caught by stage2 AstGen
* `comptime const` is redundant
* don't use `extern enum`; specify a tag type.
`extern enum` is only when you need tags to alias. But aliasing tags
is a smell. I will be making a proposal shortly to remove `extern enum`
from the language.
* there is no such thing as `packed enum`.
* instead of `catch |_|`, omit the capture entirely.
* unused function definition with missing parameter name
* using `try` outside of a function or test
Diffstat (limited to 'src/AstGen.zig')
| -rw-r--r-- | src/AstGen.zig | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/AstGen.zig b/src/AstGen.zig index 1080506192..2d34a938a7 100644 --- a/src/AstGen.zig +++ b/src/AstGen.zig @@ -2658,7 +2658,9 @@ fn fnDecl( var i: usize = 0; var it = fn_proto.iterate(tree.*); while (it.next()) |param| : (i += 1) { - const name_token = param.name_token.?; + const name_token = param.name_token orelse { + return astgen.failNode(param.type_expr, "missing parameter name", .{}); + }; const param_name = try astgen.identifierTokenString(name_token); const sub_scope = try astgen.arena.create(Scope.LocalVal); sub_scope.* = .{ |
