aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorAndrew Kelley <andrew@ziglang.org>2020-09-14 18:06:19 -0700
committerAndrew Kelley <andrew@ziglang.org>2020-09-14 18:06:19 -0700
commitdffdb2844e0163f58507b1f4a51693f4086b7949 (patch)
treeda3eb00ed7aab988b622aa2c6e2b3c07ec8ccfb4 /lib
parent26798018b780846eb0613b2061835985bf0c58ea (diff)
downloadzig-dffdb2844e0163f58507b1f4a51693f4086b7949.tar.gz
zig-dffdb2844e0163f58507b1f4a51693f4086b7949.zip
track all TODO comments in BRANCH_TODO file
Before merging, do this for every item in the file: * solve the issue, or * convert the task to a github issue and update the comment to link to the issue (and remove "TODO" text from the comment). Then delete the file. Related: #363
Diffstat (limited to 'lib')
-rw-r--r--lib/std/child_process.zig4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/std/child_process.zig b/lib/std/child_process.zig
index 9219b05088..82ed938f33 100644
--- a/lib/std/child_process.zig
+++ b/lib/std/child_process.zig
@@ -213,7 +213,7 @@ pub const ChildProcess = struct {
const stdout_in = child.stdout.?.inStream();
const stderr_in = child.stderr.?.inStream();
- // TODO need to poll to read these streams to prevent a deadlock (or rely on evented I/O).
+ // TODO https://github.com/ziglang/zig/issues/6343
const stdout = try stdout_in.readAllAlloc(args.allocator, args.max_output_bytes);
errdefer args.allocator.free(stdout);
const stderr = try stderr_in.readAllAlloc(args.allocator, args.max_output_bytes);
@@ -485,7 +485,7 @@ pub const ChildProcess = struct {
const any_ignore = (self.stdin_behavior == StdIo.Ignore or self.stdout_behavior == StdIo.Ignore or self.stderr_behavior == StdIo.Ignore);
const nul_handle = if (any_ignore)
- // "\Device\Null" or "\??\NUL"
+ // "\Device\Null" or "\??\NUL"
windows.OpenFile(&[_]u16{ '\\', 'D', 'e', 'v', 'i', 'c', 'e', '\\', 'N', 'u', 'l', 'l' }, .{
.access_mask = windows.GENERIC_READ | windows.SYNCHRONIZE,
.share_access = windows.FILE_SHARE_READ,