diff options
| author | mlugg <mlugg@mlugg.co.uk> | 2024-03-01 23:45:11 +0000 |
|---|---|---|
| committer | mlugg <mlugg@mlugg.co.uk> | 2024-03-01 23:54:31 +0000 |
| commit | 6a87e42c2ea070a6273317bbb005029d95ceae49 (patch) | |
| tree | 2b484cdc2b5f8d25a81e67f6bb8df8f0d2b0600a /lib/std/http/Client.zig | |
| parent | 36d0afbf2871ddaa6717807ae0050cb06cb2cd0d (diff) | |
| download | zig-6a87e42c2ea070a6273317bbb005029d95ceae49.tar.gz zig-6a87e42c2ea070a6273317bbb005029d95ceae49.zip | |
AstGen: fix latent bug causing incorrect elision of `dbg_stmt` instructions
Thanks to jacobly0 for figuring this out. The chain of events causing
the failure this triggered is as follows.
* As of a recent commit, certain bodies no longer emit a redundant
`block`, meaning there are more likely to be "interesting"
instructions (i.e. not blocks) at the end of parent GenZir scopes.
* When emitting the first `dbg_stmt` in such a body, the elision logic
incorrectly looks at a tag from an instruction in an enclosing scope.
* The tag of this instruction may be `undefined`, meaning that in unsafe
builds it may be incorrectly identified as a `dbg_stmt` instruction.
* This instruction from another body is clobbered rather than emitting
an actual `dbg_stmt` instruction. Note that this does not produce
invalid ZIR, since the creator of the undefined instruction replaces
the previously-undefined payload later.
Diffstat (limited to 'lib/std/http/Client.zig')
0 files changed, 0 insertions, 0 deletions
