aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuuk de Gram <luuk@degram.dev>2022-10-18 17:20:08 +0200
committerLuuk de Gram <luuk@degram.dev>2022-10-18 17:20:08 +0200
commitc0fe135ff3ec09c71103f382cdca60506b557e57 (patch)
treee6b9409580b65d6ff55e09fb805a213332462f6c
parent10b56b21d4f37f7a79562deb3bc6a53ce6da0eb0 (diff)
downloadzig-c0fe135ff3ec09c71103f382cdca60506b557e57.tar.gz
zig-c0fe135ff3ec09c71103f382cdca60506b557e57.zip
test/link: remove redundant dependOn statements
`runAndCompare` will already depend on the `CheckObject` step itself so it's not needed to also have the test step depend on the check object step.
-rw-r--r--test/link/macho/dead_strip/build.zig2
-rw-r--r--test/link/macho/dylib/build.zig2
-rw-r--r--test/link/macho/entry/build.zig1
-rw-r--r--test/link/macho/needed_library/build.zig1
-rw-r--r--test/link/macho/search_strategy/build.zig1
-rw-r--r--test/link/macho/stack_size/build.zig1
-rw-r--r--test/link/macho/weak_library/build.zig2
7 files changed, 0 insertions, 10 deletions
diff --git a/test/link/macho/dead_strip/build.zig b/test/link/macho/dead_strip/build.zig
index 1f245fc245..25759f5619 100644
--- a/test/link/macho/dead_strip/build.zig
+++ b/test/link/macho/dead_strip/build.zig
@@ -16,7 +16,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkInSymtab();
check.checkNext("{*} (__TEXT,__text) external _iAmUnused");
- test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
run_cmd.expectStdOutEqual("Hello!\n");
@@ -31,7 +30,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkInSymtab();
check.checkNotPresent("{*} (__TEXT,__text) external _iAmUnused");
- test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
run_cmd.expectStdOutEqual("Hello!\n");
diff --git a/test/link/macho/dylib/build.zig b/test/link/macho/dylib/build.zig
index a4b10eb807..a5baf255c6 100644
--- a/test/link/macho/dylib/build.zig
+++ b/test/link/macho/dylib/build.zig
@@ -40,8 +40,6 @@ pub fn build(b: *Builder) void {
check_exe.checkNext("current version 10000");
check_exe.checkNext("compatibility version 10000");
- test_step.dependOn(&check_exe.step);
-
check_exe.checkStart("cmd RPATH");
check_exe.checkNext(std.fmt.allocPrint(b.allocator, "path {s}", .{b.pathFromRoot("zig-out/lib")}) catch unreachable);
diff --git a/test/link/macho/entry/build.zig b/test/link/macho/entry/build.zig
index 6f63576e0b..0ecca14aa2 100644
--- a/test/link/macho/entry/build.zig
+++ b/test/link/macho/entry/build.zig
@@ -26,7 +26,6 @@ pub fn build(b: *Builder) void {
check_exe.checkNext("{n_value} (__TEXT,__text) external _non_main");
check_exe.checkComputeCompare("vmaddr entryoff +", .{ .op = .eq, .value = .{ .variable = "n_value" } });
- test_step.dependOn(&check_exe.step);
const run = check_exe.runAndCompare();
run.expectStdOutEqual("42");
diff --git a/test/link/macho/needed_library/build.zig b/test/link/macho/needed_library/build.zig
index a1218560e8..a314fd2201 100644
--- a/test/link/macho/needed_library/build.zig
+++ b/test/link/macho/needed_library/build.zig
@@ -31,7 +31,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkStart("cmd LOAD_DYLIB");
check.checkNext("name @rpath/liba.dylib");
- test_step.dependOn(&check.step);
const run_cmd = check.runAndCompare();
test_step.dependOn(&run_cmd.step);
diff --git a/test/link/macho/search_strategy/build.zig b/test/link/macho/search_strategy/build.zig
index d497a6499b..e556b5bb23 100644
--- a/test/link/macho/search_strategy/build.zig
+++ b/test/link/macho/search_strategy/build.zig
@@ -17,7 +17,6 @@ pub fn build(b: *Builder) void {
const check = exe.checkObject(.macho);
check.checkStart("cmd LOAD_DYLIB");
check.checkNext("name @rpath/liba.dylib");
- test_step.dependOn(&check.step);
const run = check.runAndCompare();
run.cwd = b.pathFromRoot(".");
diff --git a/test/link/macho/stack_size/build.zig b/test/link/macho/stack_size/build.zig
index c32261b533..91c44baf52 100644
--- a/test/link/macho/stack_size/build.zig
+++ b/test/link/macho/stack_size/build.zig
@@ -18,7 +18,6 @@ pub fn build(b: *Builder) void {
const check_exe = exe.checkObject(.macho);
check_exe.checkStart("cmd MAIN");
check_exe.checkNext("stacksize 100000000");
- test_step.dependOn(&check_exe.step);
const run = check_exe.runAndCompare();
test_step.dependOn(&run.step);
diff --git a/test/link/macho/weak_library/build.zig b/test/link/macho/weak_library/build.zig
index beecddb91d..8c41e0dfd1 100644
--- a/test/link/macho/weak_library/build.zig
+++ b/test/link/macho/weak_library/build.zig
@@ -33,8 +33,6 @@ pub fn build(b: *Builder) void {
check.checkNext("(undefined) weak external _a (from liba)");
check.checkNext("(undefined) weak external _asStr (from liba)");
- test_step.dependOn(&check.step);
-
const run_cmd = check.runAndCompare();
run_cmd.expectStdOutEqual("42 42");
test_step.dependOn(&run_cmd.step);