aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLemonBoy <thatlemon@gmail.com>2019-10-13 12:13:41 +0200
committerLemonBoy <thatlemon@gmail.com>2019-10-13 12:13:41 +0200
commitb1f3f59d660bbe163502daa6f0acd560782f49d8 (patch)
tree67148819b3445ecfc9dbaf3d87229bfcea8abe39
parentba711f1115b76d85b13fc64636c4a4af8405cc1e (diff)
downloadzig-b1f3f59d660bbe163502daa6f0acd560782f49d8.tar.gz
zig-b1f3f59d660bbe163502daa6f0acd560782f49d8.zip
Fix fp-based backtracing on RISC-V
The fp points to the top of the frame instead of pointing to the old fp, compensate this difference with an offset.
-rw-r--r--lib/std/debug.zig21
1 files changed, 15 insertions, 6 deletions
diff --git a/lib/std/debug.zig b/lib/std/debug.zig
index a6bc0fedf3..41270bcd82 100644
--- a/lib/std/debug.zig
+++ b/lib/std/debug.zig
@@ -280,14 +280,23 @@ pub const StackIterator = struct {
};
}
+ // On some architectures such as x86 the frame pointer is the address where
+ // the previous fp is stored, while on some other architectures such as
+ // RISC-V it points to the "top" of the frame, just above where the previous
+ // fp and the return address are stored.
+ const fp_adjust_factor = if (builtin.arch == .riscv32 or builtin.arch == .riscv64)
+ 2 * @sizeOf(usize)
+ else
+ 0;
+
fn next(self: *StackIterator) ?usize {
- if (self.fp == 0) return null;
- self.fp = @intToPtr(*const usize, self.fp).*;
- if (self.fp == 0) return null;
+ if (self.fp < fp_adjust_factor) return null;
+ self.fp = @intToPtr(*const usize, self.fp - fp_adjust_factor).*;
+ if (self.fp < fp_adjust_factor) return null;
if (self.first_addr) |addr| {
- while (self.fp != 0) : (self.fp = @intToPtr(*const usize, self.fp).*) {
- const return_address = @intToPtr(*const usize, self.fp + @sizeOf(usize)).*;
+ while (self.fp >= fp_adjust_factor) : (self.fp = @intToPtr(*const usize, self.fp - fp_adjust_factor).*) {
+ const return_address = @intToPtr(*const usize, self.fp - fp_adjust_factor + @sizeOf(usize)).*;
if (addr == return_address) {
self.first_addr = null;
return return_address;
@@ -295,7 +304,7 @@ pub const StackIterator = struct {
}
}
- const return_address = @intToPtr(*const usize, self.fp + @sizeOf(usize)).*;
+ const return_address = @intToPtr(*const usize, self.fp - fp_adjust_factor + @sizeOf(usize)).*;
return return_address;
}
};