big refactor (#171)v1.10.0-rc1

* use in-file macros rather than global funcs for registering dll load callbacks

* move more things to macros

* fix debug crashes

* move sqvm funcs to sq managers

* get rid of context file

* refactor some squirrel stuff and ingame compilation error message

* move tier0 and playlist funcs to namespaces

* uiscript_reset concommand: don't loop forever if compilation fails

* improve showing console for ui script compile errors

* standardise concommand func naming in c++

* use lambdas for dll load callbacks so intellisense shits itself less

* use cvar change callbacks for unescaping ns_server_name and ns_server_desc

* add proper helpstrings to masterserver cvars

* add cvar help and find

* allow parsing of convar flags from string

* normalise mod fs paths to be lowercase

* move hoststate to its own file and add host_init hooks

* better IsFlagSet def

* replace files in ReadFromCache

* rename g_ModManager to g_pModManager

* formatting changes

* make cvar print work on dedi, move demo fix stuff, add findflags

* add proper map autocompletes and maps command

* formatting changes

* separate gameutils into multiple r2 headers

* Update keyvalues.cpp

* move sqvm funcs into wrappers in the manager class

* remove unnecessary header files

* lots of cleanup and starting moving to new hooking macros

* update more stuff to new hook macros

* rename project folder (:tf: commit log)

* fix up postbuild commands to use relative dir

* almost fully replaced hooking lib

* completely remove old hooking

* add nsprefix because i forgot to include it

* move exploit prevention and limits code out of serverauthentication, and have actual defs for CBasePlayer

* use modular ServerPresence system for registering servers

* add new memory lib

* accidentally pushed broke code oops

* lots of stuff idk

* implement some more prs

* improve rpakfilesystem

* fix line endings on vcxproj

* Revert "fix line endings on vcxproj"

This reverts commit 4ff7d022d2602c2dba37beba8b8df735cf5cd7d9.

* add more prs

* i swear i committed these how are they not there

* Add ability to load Datatables from files (#238)

* first version of kinda working custom datatables

* Fix copy error

* Finish custom datatables

* Fix Merge

* Fix line endings

* Add fallback to rpak when ns_prefere_datatable_from_disk is true

* fix typo

* Bug fixess

* Fix Function Registration hook

* Set convar value

* Fix Client and Ui VM

* enable server auth with ms agian

* Add Filters

* FIx unused import

* Merge remote-tracking branch 'upsteam/bobs-big-refactor-pr' into datatables

Co-authored-by: RoyalBlue1 <realEmail@veryRealURL.com>

* Add some changes from main to refactor (#243)

* Add PR template

* Update CI folder location

* Delete startup args txt files

* Fix line endings (hopefully) (#244)

* Fix line endings (hopefully)

* Fix more line endings

* Update refactor (#250)

* Add PR template

* Update CI folder location

* Delete startup args txt files

* Add editorconfig file (#246)

* Add editorconfig file

It's a cross-editor compatible config file that defines certain editor
behaviour (e.g. adding/removing newline at end of file)

It is supported by major editors like Visual Studio (Code) and by
version control  providers like GitHub.

Should end the constant adding/removing of final newline in PRs

* More settings

- unicode by default
- trim newlines
- use tabs for indentation (ugh)

* Ignore folder rename (#245)

* Hot reload banlist on player join (#233)

* added banlist hotreload

* fix formatting

* didnt append, cleared whole file oopsie

* unfuckedunban not rewriting file

* fixed not checking for new line

Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>

* Refactor cleanup (#256)

* Fix indentation

* Fix path in clang-format command in readme

* Refactor cleanup (some formatting fixes) (#257)

* Fix some formatting

* More formatting fixes

* add scriptdatatable.cpp rewrite

* Some formatting fixes (#260)

* More formatting stuff (#261)

* various formatting changes and fixes

* Fix changed icon (#264)

* clang format, fix issues with server registration and rpak loading

* fix more formatting

* update postbuild step

* set launcher directory and error on fail creating log files

* change some stuff in exploitfixes

* only unrestrict dev commands when commandline flag is present

* fix issues with cvar flag commit

* fixup command flags better and reformat

* bring up to date with main

* fixup formatting

* improve cvar flag fixup and remove temp thing from findflags

* set serverfilter better

* avoid ptr decay when setting auth token

* add more entity functions

* Fix the MS server registration issues. (#285)

* Port ms presence reporter to std::async

* Fix crash due to std::optional being assigned nullptr.

* Fix formatting.

* Wait 20 seconds if MS returns DUPLICATE_SERVER.

* Change PERSISTENCE_MAX_SIZE to fix player authentication (#287)

The size check added in the refactor was incorrect:

- 56306: expected pdata size based on the pdef
- 512: allowance for trailing junk (r2 adds 137 bytes of trailing junk)
- 100: for some wiggle room

Co-Authored-By: pg9182 <96569817+pg9182@users.noreply.github.com>

* change miscserverscript to use actual entity arguments rather than
player index jank

* Fix token clearing hook (#290)

A certain someone forgot to put an `0x` in front of their hex number, meaning the offset is wrong.
This would cause token to be leaked again

Co-authored-by: Maya <malte.hoermeyer@web.de>
Co-authored-by: RoyalBlue1 <realEmail@veryRealURL.com>
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Co-authored-by: ScureX <47725553+ScureX@users.noreply.github.com>
Co-authored-by: Erlite <ys.aameziane@gmail.com>
Co-authored-by: Emma Miler <emma.pi@protonmail.com>
Co-authored-by: pg9182 <96569817+pg9182@users.noreply.github.com>

1 files changed, 206 insertions, 0 deletions

diff --git a/NorthstarDLL/r2engine.h b/NorthstarDLL/r2engine.h
new file mode 100644
index 00000000..1d67e8c1
--- /dev/null
+++ b/NorthstarDLL/r2engine.h
@@ -0,0 +1,206 @@
+#pragma once
+
+// use the R2 namespace for game funcs
+namespace R2
+{
+	// Cbuf
+	enum class ECommandTarget_t
+	{
+		CBUF_FIRST_PLAYER = 0,
+		CBUF_LAST_PLAYER = 1, // MAX_SPLITSCREEN_CLIENTS - 1, MAX_SPLITSCREEN_CLIENTS = 2
+		CBUF_SERVER = CBUF_LAST_PLAYER + 1,
+
+		CBUF_COUNT,
+	};
+
+	enum class cmd_source_t
+	{
+		// Added to the console buffer by gameplay code.  Generally unrestricted.
+		kCommandSrcCode,
+
+		// Sent from code via engine->ClientCmd, which is restricted to commands visible
+		// via FCVAR_GAMEDLL_FOR_REMOTE_CLIENTS.
+		kCommandSrcClientCmd,
+
+		// Typed in at the console or via a user key-bind.  Generally unrestricted, although
+		// the client will throttle commands sent to the server this way to 16 per second.
+		kCommandSrcUserInput,
+
+		// Came in over a net connection as a clc_stringcmd
+		// host_client will be valid during this state.
+		//
+		// Restricted to FCVAR_GAMEDLL commands (but not convars) and special non-ConCommand
+		// server commands hardcoded into gameplay code (e.g. "joingame")
+		kCommandSrcNetClient,
+
+		// Received from the server as the client
+		//
+		// Restricted to commands with FCVAR_SERVER_CAN_EXECUTE
+		kCommandSrcNetServer,
+
+		// Being played back from a demo file
+		//
+		// Not currently restricted by convar flag, but some commands manually ignore calls
+		// from this source.  FIXME: Should be heavily restricted as demo commands can come
+		// from untrusted sources.
+		kCommandSrcDemoFile,
+
+		// Invalid value used when cleared
+		kCommandSrcInvalid = -1
+	};
+
+	typedef ECommandTarget_t (*Cbuf_GetCurrentPlayerType)();
+	extern Cbuf_GetCurrentPlayerType Cbuf_GetCurrentPlayer;
+
+	typedef void (*Cbuf_AddTextType)(ECommandTarget_t eTarget, const char* text, cmd_source_t source);
+	extern Cbuf_AddTextType Cbuf_AddText;
+
+	typedef void (*Cbuf_ExecuteType)();
+	extern Cbuf_ExecuteType Cbuf_Execute;
+
+	// CEngine
+
+	enum EngineQuitState
+	{
+		QUIT_NOTQUITTING = 0,
+		QUIT_TODESKTOP,
+		QUIT_RESTART
+	};
+
+	enum class EngineState_t
+	{
+		DLL_INACTIVE = 0, // no dll
+		DLL_ACTIVE, // engine is focused
+		DLL_CLOSE, // closing down dll
+		DLL_RESTART, // engine is shutting down but will restart right away
+		DLL_PAUSED, // engine is paused, can become active from this state
+	};
+
+	class CEngine
+	{
+	  public:
+		virtual void unknown() {} // unsure if this is where
+		virtual bool Load(bool dedicated, const char* baseDir) {}
+		virtual void Unload() {}
+		virtual void SetNextState(EngineState_t iNextState) {}
+		virtual EngineState_t GetState() {}
+		virtual void Frame() {}
+		virtual double GetFrameTime() {}
+		virtual float GetCurTime() {}
+
+		EngineQuitState m_nQuitting;
+		EngineState_t m_nDllState;
+		EngineState_t m_nNextDllState;
+		double m_flCurrentTime;
+		float m_flFrameTime;
+		double m_flPreviousTime;
+		float m_flFilteredTime;
+		float m_flMinFrameTime; // Expected duration of a frame, or zero if it is unlimited.
+	};
+
+	extern CEngine* g_pEngine;
+
+	extern void (*CBaseClient__Disconnect)(void* self, uint32_t unknownButAlways1, const char* reason, ...);
+
+#pragma once
+	typedef enum
+	{
+		NA_NULL = 0,
+		NA_LOOPBACK,
+		NA_IP,
+	} netadrtype_t;
+
+#pragma pack(push, 1)
+	typedef struct netadr_s
+	{
+		netadrtype_t type;
+		unsigned char ip[16]; // IPv6
+		// IPv4's 127.0.0.1 is [::ffff:127.0.0.1], that is:
+		// 00 00 00 00 00 00 00 00    00 00 FF FF 7F 00 00 01
+		unsigned short port;
+	} netadr_t;
+#pragma pack(pop)
+
+#pragma pack(push, 1)
+	typedef struct netpacket_s
+	{
+		netadr_t adr; // sender address
+		// int				source;		// received source
+		char unk[10];
+		double received_time;
+		unsigned char* data; // pointer to raw packet data
+		void* message; // easy bitbuf data access // 'inpacket.message' etc etc (pointer)
+		char unk2[16];
+		int size;
+
+		// bf_read			message;	// easy bitbuf data access // 'inpacket.message' etc etc (pointer)
+		// int				size;		// size in bytes
+		// int				wiresize;   // size in bytes before decompression
+		// bool			stream;		// was send as stream
+		// struct netpacket_s* pNext;	// for internal use, should be NULL in public
+	} netpacket_t;
+#pragma pack(pop)
+
+	// #56169 $DB69 PData size
+	// #512   $200	Trailing data
+	// #100	  $64	Safety buffer
+	const int PERSISTENCE_MAX_SIZE = 0xDDCD;
+
+	// note: NOT_READY and READY are the only entries we have here that are defined by the vanilla game
+	// entries after this are custom and used to determine the source of persistence, e.g. whether it is local or remote
+	enum class ePersistenceReady : char
+	{
+		NOT_READY,
+		READY = 3,
+		READY_INSECURE = 3,
+		READY_REMOTE
+	};
+
+#pragma pack(push, 1)
+	struct CBaseClient // 0x2D728 bytes
+	{
+		char pad0[0x16];
+
+		// +0x16
+		char m_Name[64];
+
+		// +0x56
+		char pad1[0x202];
+
+		void** m_ConVars; // this is a KeyValues* object but not got that struct mapped out atm
+
+		char pad2[0x240];
+
+		// +0x4A0
+		ePersistenceReady m_iPersistenceReady;
+		// +0x4A1
+
+		char pad3[0x59];
+
+		// +0x4FA
+		char m_PersistenceBuffer[PERSISTENCE_MAX_SIZE];
+
+		char pad4[0x2006];
+
+		// +0xF500
+		char m_UID[32];
+		// +0xF520
+
+		char pad5[0x1E208];
+	};
+#pragma pack(pop)
+
+	extern CBaseClient* g_pClientArray;
+
+	enum server_state_t
+	{
+		ss_dead = 0, // Dead
+		ss_loading, // Spawning
+		ss_active, // Running
+		ss_paused, // Running, but paused
+	};
+
+	extern server_state_t* g_pServerState;
+
+	extern char* g_pModName;
+} // namespace R2