diff options
| author | EladNLG <e1lad8955@gmail.com> | 2024-07-05 00:25:07 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-04 23:25:07 +0200 |
| commit | afa246978001db279d3e0eabbbe6b32f5c42e1f4 (patch) | |
| tree | 93ba4acf7c7ced8a5363428b8930c31c07f2af2c | |
| parent | 193ab4905664259cbb5035b0ec9b2cb3e0e6a994 (diff) | |
| download | NorthstarLauncher-afa246978001db279d3e0eabbbe6b32f5c42e1f4.tar.gz NorthstarLauncher-afa246978001db279d3e0eabbbe6b32f5c42e1f4.zip | |
Make Script Errors from Northstar Callbacks Fatal (#698)v1.26.0-rc2
Because:
- Errors are incredibly confusing when non-fatal - there is no indicator that an error is happening
- The error is unknown without a try/catch block
- Errors cannot be tracked to a line, or file, and its location has to be figured out manually
- They can throw a game into an unexpected state with no indicator, confusing both players AND developers
| -rw-r--r-- | primedev/squirrel/squirrel.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/primedev/squirrel/squirrel.h b/primedev/squirrel/squirrel.h index 0c1f24d3..1054de7f 100644 --- a/primedev/squirrel/squirrel.h +++ b/primedev/squirrel/squirrel.h @@ -136,7 +136,7 @@ public: inline SQRESULT _call(HSquirrelVM* sqvm, const SQInteger args) { - return __sq_call(sqvm, args + 1, false, false); + return __sq_call(sqvm, args + 1, false, true); } inline SQInteger raiseerror(HSquirrelVM* sqvm, const SQChar* sError) |