From afa246978001db279d3e0eabbbe6b32f5c42e1f4 Mon Sep 17 00:00:00 2001 From: EladNLG Date: Fri, 5 Jul 2024 00:25:07 +0300 Subject: Make Script Errors from Northstar Callbacks Fatal (#698) Because: - Errors are incredibly confusing when non-fatal - there is no indicator that an error is happening - The error is unknown without a try/catch block - Errors cannot be tracked to a line, or file, and its location has to be figured out manually - They can throw a game into an unexpected state with no indicator, confusing both players AND developers --- primedev/squirrel/squirrel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/primedev/squirrel/squirrel.h b/primedev/squirrel/squirrel.h index 0c1f24d3..1054de7f 100644 --- a/primedev/squirrel/squirrel.h +++ b/primedev/squirrel/squirrel.h @@ -136,7 +136,7 @@ public: inline SQRESULT _call(HSquirrelVM* sqvm, const SQInteger args) { - return __sq_call(sqvm, args + 1, false, false); + return __sq_call(sqvm, args + 1, false, true); } inline SQInteger raiseerror(HSquirrelVM* sqvm, const SQChar* sError) -- cgit v1.2.3