diff options
| author | Jacob Young <jacobly0@users.noreply.github.com> | 2023-11-22 20:09:54 -0500 |
|---|---|---|
| committer | Jacob Young <jacobly0@users.noreply.github.com> | 2023-11-23 04:38:31 -0500 |
| commit | 115ec25f2e4eed5033f34eaee8bf3477ff417ecc (patch) | |
| tree | d7bfc1bbc3cea5ce520e3bcf0b12e131ae04ac75 /src | |
| parent | fcc071c9bd6b0c8e010957156505878ea6c0c55d (diff) | |
| download | zig-115ec25f2e4eed5033f34eaee8bf3477ff417ecc.tar.gz zig-115ec25f2e4eed5033f34eaee8bf3477ff417ecc.zip | |
x86_64: optimize compile time of `mnemonic_to_encodings_map`
Remove all comptime sorts, making it compile 3x faster.
Diffstat (limited to 'src')
| -rw-r--r-- | src/arch/x86_64/Encoding.zig | 42 |
1 files changed, 19 insertions, 23 deletions
diff --git a/src/arch/x86_64/Encoding.zig b/src/arch/x86_64/Encoding.zig index f41c0f253a..21b1168bb4 100644 --- a/src/arch/x86_64/Encoding.zig +++ b/src/arch/x86_64/Encoding.zig @@ -812,36 +812,32 @@ fn estimateInstructionLength(prefix: Prefix, encoding: Encoding, ops: []const Op } const mnemonic_to_encodings_map = init: { - @setEvalBranchQuota(60_000); + @setEvalBranchQuota(4_000); + const mnemonic_count = @typeInfo(Mnemonic).Enum.fields.len; + var mnemonic_map: [mnemonic_count][]Data = .{&.{}} ** mnemonic_count; const encodings = @import("encodings.zig"); - var entries = encodings.table; - std.mem.sort(encodings.Entry, &entries, {}, struct { - fn lessThan(_: void, lhs: encodings.Entry, rhs: encodings.Entry) bool { - return @intFromEnum(lhs[0]) < @intFromEnum(rhs[0]); - } - }.lessThan); - var data_storage: [entries.len]Data = undefined; - var mnemonic_map: [@typeInfo(Mnemonic).Enum.fields.len][]const Data = undefined; - var mnemonic_int = 0; - var mnemonic_start = 0; - for (&data_storage, entries, 0..) |*data, entry, data_index| { - data.* = .{ + for (encodings.table) |entry| mnemonic_map[@intFromEnum(entry[0])].len += 1; + var data_storage: [encodings.table.len]Data = undefined; + var storage_i: usize = 0; + for (&mnemonic_map) |*value| { + value.ptr = data_storage[storage_i..].ptr; + storage_i += value.len; + } + var mnemonic_i: [mnemonic_count]usize = .{0} ** mnemonic_count; + const ops_len = @typeInfo(std.meta.FieldType(Data, .ops)).Array.len; + const opc_len = @typeInfo(std.meta.FieldType(Data, .opc)).Array.len; + for (encodings.table) |entry| { + const i = &mnemonic_i[@intFromEnum(entry[0])]; + mnemonic_map[@intFromEnum(entry[0])][i.*] = .{ .op_en = entry[1], - .ops = (entry[2] ++ .{.none} ** (data.ops.len - entry[2].len)).*, + .ops = (entry[2] ++ .{.none} ** (ops_len - entry[2].len)).*, .opc_len = entry[3].len, - .opc = (entry[3] ++ .{undefined} ** (data.opc.len - entry[3].len)).*, + .opc = (entry[3] ++ .{undefined} ** (opc_len - entry[3].len)).*, .modrm_ext = entry[4], .mode = entry[5], .feature = entry[6], }; - while (mnemonic_int < @intFromEnum(entry[0])) : (mnemonic_int += 1) { - mnemonic_map[mnemonic_int] = data_storage[mnemonic_start..data_index]; - mnemonic_start = data_index; - } - } - while (mnemonic_int < mnemonic_map.len) : (mnemonic_int += 1) { - mnemonic_map[mnemonic_int] = data_storage[mnemonic_start..]; - mnemonic_start = data_storage.len; + i.* += 1; } break :init mnemonic_map; }; |
