diff options
| author | joachimschmidt557 <joachim.schmidt557@outlook.com> | 2020-10-16 18:32:02 +0200 |
|---|---|---|
| committer | joachimschmidt557 <joachim.schmidt557@outlook.com> | 2020-10-25 12:51:19 +0100 |
| commit | 7d14426da49fcb42b69d41a36935cf65ad70c697 (patch) | |
| tree | 3796759fce8718de1f205c918fba1581e2647c8d /src/codegen.zig | |
| parent | 0e16328636c29b4d82331744cfa1eaad1b7a8507 (diff) | |
| download | zig-7d14426da49fcb42b69d41a36935cf65ad70c697.tar.gz zig-7d14426da49fcb42b69d41a36935cf65ad70c697.zip | |
stage2 ARM: enable backpatching return statement
Diffstat (limited to 'src/codegen.zig')
| -rw-r--r-- | src/codegen.zig | 47 |
1 files changed, 38 insertions, 9 deletions
diff --git a/src/codegen.zig b/src/codegen.zig index 2cc85a7cd2..01ebbe85ae 100644 --- a/src/codegen.zig +++ b/src/codegen.zig @@ -587,11 +587,36 @@ fn Function(comptime arch: std.Target.Cpu.Arch) type { try self.dbgSetEpilogueBegin(); + // exitlude jumps + if (self.exitlude_jump_relocs.items.len == 1) { + // There is only one relocation. Hence, + // this relocation must be at the end of + // the code. Therefore, we can just delete + // the space initially reserved for the + // jump + self.code.items.len -= 4; + } else for (self.exitlude_jump_relocs.items) |jmp_reloc| { + const amt = self.code.items.len - (jmp_reloc + 4); + if (amt == 0) { + // This return is at the end of the + // code block. We can't just delete + // the space because there may be + // other jumps we already relocated to + // the address. Instead, insert a nop + mem.writeIntLittle(u32, self.code.items[jmp_reloc..][0..4], Instruction.nop().toU32()); + } else { + if (math.cast(i26, amt)) |offset| { + mem.writeIntLittle(u32, self.code.items[jmp_reloc..][0..4], Instruction.b(.al, offset).toU32()); + } else |err| { + return self.fail(self.src, "exitlude jump is too large", .{}); + } + } + } + // mov sp, fp // pop {fp, pc} - // TODO: return by jumping to this code, use relocations - // mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.mov(.al, .sp, Instruction.Operand.reg(.fp, Instruction.Operand.Shift.none)).toU32()); - // mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.pop(.al, .{ .fp, .pc }).toU32()); + mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.mov(.al, .sp, Instruction.Operand.reg(.fp, Instruction.Operand.Shift.none)).toU32()); + mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.pop(.al, .{ .fp, .pc }).toU32()); } else { try self.dbgSetPrologueEnd(); try self.genBody(self.mod_fn.analysis.success); @@ -1661,12 +1686,9 @@ fn Function(comptime arch: std.Target.Cpu.Arch) type { mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.jalr(.zero, 0, .ra).toU32()); }, .arm => { - mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.mov(.al, .sp, Instruction.Operand.reg(.fp, Instruction.Operand.Shift.none)).toU32()); - mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.pop(.al, .{ .fp, .pc }).toU32()); - // TODO: jump to the end with relocation - // // Just add space for an instruction, patch this later - // try self.code.resize(self.code.items.len + 4); - // try self.exitlude_jump_relocs.append(self.gpa, self.code.items.len - 4); + // Just add space for an instruction, patch this later + try self.code.resize(self.code.items.len + 4); + try self.exitlude_jump_relocs.append(self.gpa, self.code.items.len - 4); }, else => return self.fail(src, "TODO implement return for {}", .{self.target.cpu.arch}), } @@ -1932,6 +1954,13 @@ fn Function(comptime arch: std.Target.Cpu.Arch) type { mem.writeIntLittle(i32, self.code.addManyAsArrayAssumeCapacity(4), delta); } }, + .arm => { + if (math.cast(i26, @intCast(i32, index) - @intCast(i32, self.code.items.len))) |delta| { + mem.writeIntLittle(u32, try self.code.addManyAsArray(4), Instruction.b(.al, delta).toU32()); + } else |err| { + return self.fail(src, "TODO: enable larger branch offset", .{}); + } + }, else => return self.fail(src, "TODO implement jump for {}", .{self.target.cpu.arch}), } } |
