aboutsummaryrefslogtreecommitdiff
path: root/lib/std/debug/cpu_context.zig
diff options
context:
space:
mode:
authormlugg <mlugg@mlugg.co.uk>2025-09-20 15:16:42 +0100
committermlugg <mlugg@mlugg.co.uk>2025-09-30 13:44:56 +0100
commitf7e0ff8a5fb3e8426e8f64bba271eae358d123b4 (patch)
tree32056a86cbcf95e4c64750ddb704c0b7d6390ddb /lib/std/debug/cpu_context.zig
parentb0f222777c38088d90041ba1f28bfb1341cc76c6 (diff)
downloadzig-f7e0ff8a5fb3e8426e8f64bba271eae358d123b4.tar.gz
zig-f7e0ff8a5fb3e8426e8f64bba271eae358d123b4.zip
std: clarify cpu_context register order rationale
Diffstat (limited to 'lib/std/debug/cpu_context.zig')
-rw-r--r--lib/std/debug/cpu_context.zig9
1 files changed, 6 insertions, 3 deletions
diff --git a/lib/std/debug/cpu_context.zig b/lib/std/debug/cpu_context.zig
index fdf6ebd243..6499de21b1 100644
--- a/lib/std/debug/cpu_context.zig
+++ b/lib/std/debug/cpu_context.zig
@@ -225,8 +225,9 @@ pub fn fromWindowsContext(ctx: *const std.os.windows.CONTEXT) Native {
}
pub const X86 = struct {
- /// The first 8 registers here intentionally match the order of registers pushed
- /// by PUSHA, which is also the order used by the DWARF register mappings.
+ /// The first 8 registers here intentionally match the order of registers in the x86 instruction
+ /// encoding. This order is inherited by the PUSHA instruction and the DWARF register mappings,
+ /// among other things.
pub const Gpr = enum {
// zig fmt: off
eax, ecx, edx, ebx,
@@ -283,7 +284,9 @@ pub const X86 = struct {
};
pub const X86_64 = struct {
- /// MLUGG TODO: explain this order. why does DWARF have this?
+ /// The order here intentionally matches the order of the DWARF register mappings. It's unclear
+ /// where those mappings actually originated from---the ordering of the first 4 registers seems
+ /// quite unusual---but it is currently convenient for us to match DWARF.
pub const Gpr = enum {
// zig fmt: off
rax, rdx, rcx, rbx,