aboutsummaryrefslogtreecommitdiff
path: root/lib/std/debug.zig
diff options
context:
space:
mode:
authorAndrew Kelley <andrew@ziglang.org>2024-06-11 15:14:06 -0700
committerAndrew Kelley <andrew@ziglang.org>2024-06-12 17:09:07 -0700
commit55a9ea250cf2aad58f3c4eb49ac6ee8d2b6f5cff (patch)
treec2f20b3dc137fec4907f825de35c8208b19dc574 /lib/std/debug.zig
parent0cef727e59d7b0c34756c09f64cbfe4490dcc3e7 (diff)
downloadzig-55a9ea250cf2aad58f3c4eb49ac6ee8d2b6f5cff.tar.gz
zig-55a9ea250cf2aad58f3c4eb49ac6ee8d2b6f5cff.zip
std.debug: lock stderr mutex when panicking
The doc comments for this global said: "Locked to avoid interleaving panic messages from multiple threads." Huh? There's already a mutex for that, it's the stderr mutex. Lock that one instead.
Diffstat (limited to 'lib/std/debug.zig')
-rw-r--r--lib/std/debug.zig15
1 files changed, 6 insertions, 9 deletions
diff --git a/lib/std/debug.zig b/lib/std/debug.zig
index f431d0eb91..e7d0d23766 100644
--- a/lib/std/debug.zig
+++ b/lib/std/debug.zig
@@ -447,9 +447,6 @@ pub fn panicExtra(
/// The counter is incremented/decremented atomically.
var panicking = std.atomic.Value(u8).init(0);
-// Locked to avoid interleaving panic messages from multiple threads.
-var panic_mutex = std.Thread.Mutex{};
-
/// Counts how many times the panic handler is invoked by this thread.
/// This is used to catch and handle panics triggered by the panic handler.
threadlocal var panic_stage: usize = 0;
@@ -474,8 +471,8 @@ pub fn panicImpl(trace: ?*const std.builtin.StackTrace, first_trace_addr: ?usize
// Make sure to release the mutex when done
{
- panic_mutex.lock();
- defer panic_mutex.unlock();
+ lockStdErr();
+ defer unlockStdErr();
const stderr = io.getStdErr().writer();
if (builtin.single_threaded) {
@@ -2604,8 +2601,8 @@ fn handleSegfaultPosix(sig: i32, info: *const posix.siginfo_t, ctx_ptr: ?*anyopa
_ = panicking.fetchAdd(1, .seq_cst);
{
- panic_mutex.lock();
- defer panic_mutex.unlock();
+ lockStdErr();
+ defer unlockStdErr();
dumpSegfaultInfoPosix(sig, code, addr, ctx_ptr);
}
@@ -2680,8 +2677,8 @@ fn handleSegfaultWindowsExtra(
_ = panicking.fetchAdd(1, .seq_cst);
{
- panic_mutex.lock();
- defer panic_mutex.unlock();
+ lockStdErr();
+ defer unlockStdErr();
dumpSegfaultInfoWindows(info, msg, label);
}