aboutsummaryrefslogtreecommitdiff
path: root/src/lpm.c
diff options
context:
space:
mode:
authorAdam Harrison <adamdharrison@gmail.com>2023-05-22 15:24:57 -0400
committerAdam Harrison <adamdharrison@gmail.com>2023-05-22 15:24:57 -0400
commitea699db36145ac11ef147b611c9abf67436f3ec7 (patch)
tree0329d24440ca710f69d9f07a1ebac08d841708cc /src/lpm.c
parent2137c5bec13fce85ffb3f4bc7726b7a959e16b60 (diff)
downloadlite-xl-plugin-manager-ea699db36145ac11ef147b611c9abf67436f3ec7.tar.gz
lite-xl-plugin-manager-ea699db36145ac11ef147b611c9abf67436f3ec7.zip
Added in warning when we cannot acquire an lpm global lock, and also made it so we do not lock upon running something.
Diffstat (limited to 'src/lpm.c')
-rw-r--r--src/lpm.c25
1 files changed, 19 insertions, 6 deletions
diff --git a/src/lpm.c b/src/lpm.c
index 17da4cc..9df4890 100644
--- a/src/lpm.c
+++ b/src/lpm.c
@@ -1004,22 +1004,35 @@ int lpm_flock(lua_State* L) {
const char* path = luaL_checkstring(L, 1);
luaL_checktype(L, 2, LUA_TFUNCTION);
int error_handler = lua_type(L, 3) == LUA_TFUNCTION ? 3 : 0;
+ int warning_handler = lua_type(L, 4) == LUA_TFUNCTION ? 4 : 0;
#ifdef _WIN32
HANDLE file = CreateFileW(lua_toutf16(L, path), FILE_SHARE_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0);
if (!file || file == INVALID_HANDLE_VALUE)
return luaL_error(L, "can't open for flock %s: %d", path, GetLastError());
OVERLAPPED overlapped = {0};
- if (!LockFileEx(file, LOCKFILE_EXCLUSIVE_LOCK, 0, 0, 1, &overlapped)) {
- CloseHandle(file);
- return luaL_error(L, "can't flock %s: %d", path, GetLastError());
+ if (!LockFileEx(file, LOCKFILE_EXCLUSIVE_LOCK | LOCKFILE_FAIL_IMMEDIATELY, 0, 0, 1, &overlapped)) {
+ if (GetLastError() == ERROR_IO_PENDING && warning_handler) {
+ lua_pushvalue(L, warning_handler);
+ lua_pcall(L, 0, 0, 0);
+ }
+ if (!LockFileEx(file, LOCKFILE_EXCLUSIVE_LOCK, 0, 0, 1, &overlapped)) {
+ CloseHandle(file);
+ return luaL_error(L, "can't flock %s: %d", path, GetLastError());
+ }
}
#else
int fd = open(path, 0);
if (fd == -1)
return luaL_error(L, "can't flock %s: %s", path, strerror(errno));
- if (flock(fd, LOCK_EX) == -1) {
- close(fd);
- return luaL_error(L, "can't acquire exclusive lock on %s: %s", strerror(errno));
+ if (flock(fd, LOCK_EX | LOCK_NB) == -1) {
+ if (errno == EWOULDBLOCK && warning_handler) {
+ lua_pushvalue(L, warning_handler);
+ lua_pcall(L, 0, 0, 0);
+ }
+ if (flock(fd, LOCK_EX) == -1) {
+ close(fd);
+ return luaL_error(L, "can't acquire exclusive lock on %s: %s", strerror(errno));
+ }
}
#endif
lua_pushvalue(L, 2);