GitBook: [#47] Move Testing page into Development section

5 files changed, 46 insertions, 15 deletions

diff --git a/docs/modding-and-development/development/repositories/northstarlauncher.md b/docs/modding-and-development/development/northstarlauncher.md
index 89aeca4..89aeca4 100644
--- a/docs/modding-and-development/development/repositories/northstarlauncher.md
+++ b/docs/modding-and-development/development/northstarlauncher.md
diff --git a/docs/modding-and-development/development/northstarmasterserver/README.md b/docs/modding-and-development/development/northstarmasterserver/README.md
new file mode 100644
index 0000000..c6fbadb
--- /dev/null
+++ b/docs/modding-and-development/development/northstarmasterserver/README.md
@@ -0,0 +1,11 @@
+# NorthstarMasterServer
+
+## Introduction
+
+The master server is responsible for centralizing game servers created by players, it also verifies that connecting players own an Origin account with Titanfall 2.
+
+There's no need to host your own master server to play games with other people, you can use [direct connect](../../../installing-northstar/using-northstar/direct-connect.md) or just setup a [normal server](../../../hosting-a-server-with-northstar/basic-listen-server.md) that announces itself to `northstar.tf`. This tutorial is aimed for those who want to contribute improvements to the code or test their own changes to the project.
+
+## Contents
+
+* [Deploy](deploy.md)
diff --git a/docs/modding-and-development/development/repositories/northstarmasterserver/deploy.md b/docs/modding-and-development/development/northstarmasterserver/deploy.md
index e1d5985..c384730 100644
--- a/docs/modding-and-development/development/repositories/northstarmasterserver/deploy.md
+++ b/docs/modding-and-development/development/northstarmasterserver/deploy.md
@@ -1,4 +1,4 @@
-# Deploying Master Server
+# Deploy
 
 ## Development
 
@@ -7,10 +7,10 @@ A Development Master Server uses http requests, it should be used for developmen
 ### Installation steps
 
 1. Clone [NorthstarMasterServer](https://github.com/R2Northstar/NorthstarMasterServer).
-1. Copy the default [dev.env](https://github.com/R2Northstar/NorthstarMasterServer/blob/main/dev.env) to `.env` replace the ip with `127.0.0.1`.
-1. Run `npm install` && `npm run watch`.
+2. Copy the default [dev.env](https://github.com/R2Northstar/NorthstarMasterServer/blob/main/dev.env) to `.env` replace the ip with `127.0.0.1`.
+3. Run `npm install` && `npm run watch`.
 
-Your master server is now running, to connect to it you need to change some configuration files. 
+Your master server is now running, to connect to it you need to change some configuration files.
 
 Northstar default masterserver is https://northstar.tf, to point to a new location you need to modify this URL in the `autoexec_ns_server.cfg` and `autoexec_ns_client.cfg` config files.
 
diff --git a/docs/modding-and-development/development/repositories/northstarmasterserver/README.md b/docs/modding-and-development/development/repositories/northstarmasterserver/README.md
deleted file mode 100644
index 2b5ac8a..0000000
--- a/docs/modding-and-development/development/repositories/northstarmasterserver/README.md
+++ /dev/null
@@ -1,11 +0,0 @@
-# NorthstarMasterServer
-
-## Introduction
-
-The master server is responsible for centralizing game servers created by players, it also verifies that connecting players own an Origin account with Titanfall 2.
-
-There's no need to host your own master server to play games with other people, you can use [direct connect](../../../../installing-northstar/using-northstar/direct-connect.md) or just setup a [normal server](../../../../hosting-a-server-with-northstar/basic-listen-server.md) that announces itself to `northstar.tf`. This tutorial is aimed for those who want to contribute improvements to the code or test their own changes to the project.
-
-## Contents
-
-* [Deploy](deploy.md)
diff --git a/docs/modding-and-development/development/testing.md b/docs/modding-and-development/development/testing.md
new file mode 100644
index 0000000..6c237dd
--- /dev/null
+++ b/docs/modding-and-development/development/testing.md
@@ -0,0 +1,31 @@
+---
+description: >-
+  Instructions regarding testing new features, directed at both developers and
+  maintainers
+---
+
+# Testing
+
+{% hint style="info" %}
+This section is very much still WIP. Feel free to help expand it.
+{% endhint %}
+
+## Developers & Contributors
+
+This section applies to you if you're opening a pull request to any of the Northstar repos.
+
+Whatever your change includes, whether a bug fix or a new feature make sure to test it appropriately.
+
+This means if your change is a bug fix, it's recommend you first make sure you can reproduce the bug. Then after making the necessary changes to fix it, test it using the same method you used to originally confirm the bug. \
+When you're opening a pull request, make sure to mention how to reproduce the bug, so that reviewers can confirm that your chance indeed fixed the issue.
+
+If your change is a new feature, make sure to test both that the newly added functionality performs as expected, as well as ensuring that it doesn't introduce any form of regression bugs. This means, testing anything that might be affected by your new feature.
+
+
+## Maintainers
+
+This section applies to you if you're someone who's able to merge PRs in any of the repos of the Northstar GitHub org as well as when simplying performing reviews, even without being able to actually merge a PR.
+
+When reviewing pull requests on GitHub, make sure to checkout the changes made by a PR locally and test it there. In particular, test the parts of the code that are touched by a PR.
+
+After testing, make sure to mention the steps tested in your review.