diff options
| author | GeckoEidechse <gecko.eidechse+git@pm.me> | 2023-02-13 21:58:13 +0100 |
|---|---|---|
| committer | GeckoEidechse <gecko.eidechse+git@pm.me> | 2023-02-13 21:58:13 +0100 |
| commit | 4bf88df1f7d15348ad1fff12b35c9ff8fec3e1ad (patch) | |
| tree | 632b7245a3ff7f3c9ef7f1d990dc45adccc5e73f | |
| parent | 34eb441d923f0a2c621cd316de80a3e845879617 (diff) | |
| download | NorthstarWiki-4bf88df1f7d15348ad1fff12b35c9ff8fec3e1ad.tar.gz NorthstarWiki-4bf88df1f7d15348ad1fff12b35c9ff8fec3e1ad.zip | |
Fix typos
| -rw-r--r-- | docs/modding-and-development/development/reviewing.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/modding-and-development/development/reviewing.md b/docs/modding-and-development/development/reviewing.md index c17bba2..cefc474 100644 --- a/docs/modding-and-development/development/reviewing.md +++ b/docs/modding-and-development/development/reviewing.md @@ -45,11 +45,11 @@ The TL;DR is to test the aspect that has been changed. #### Finishing up -After you performed the testing and/or code review leave I final comment by clicking on _"Finish your review"_ on the top right of the _"Files changed"_ page of the PR. +After you performed the testing and/or code review leave a final comment by clicking on _"Finish your review"_ on the top right of the _"Files changed"_ page of the PR.  -In your final comment make sure to mention what you did, e.g. which aspects of the change you tested for or what you considered during code review (format, edge cases, ...). The more detailed this part is the easier it is for other reviewers to tell which aspects they can skip during reviewing to speed up the process. +In your final comment make sure to mention what you did, e.g. which aspects of the change you tested for or what you considered during code review (formatting, edge cases, ...). The more detailed this part is the easier it is for other reviewers to tell which aspects they can skip during reviewing to speed up the process. After leaving your comment, select the type of feedback. |