remove ClientCommandKeyValues

1 files changed, 13 insertions, 0 deletions

diff --git a/NorthstarDedicatedTest/miscserverfixes.cpp b/NorthstarDedicatedTest/miscserverfixes.cpp
index 334c5fa3..fca9c169 100644
--- a/NorthstarDedicatedTest/miscserverfixes.cpp
+++ b/NorthstarDedicatedTest/miscserverfixes.cpp
@@ -21,4 +21,17 @@ void InitialiseMiscServerFixes(HMODULE baseAddress)
 		*(ptr++) = 0x90; // nop
 		*ptr = 0x90;	 // nop
 	}
+
+	// ret at the start of CServerGameClients::ClientCommandKeyValues as it has no benefit and is forwarded to client (i.e. security issue)
+	// this prevents the attack vector of client=>server=>client, however server=>client also has clientside patches
+	{
+		char* ptr = reinterpret_cast<char*>(baseAddress) + 0x153920;
+		TempReadWrite rw(ptr);
+		*ptr = 0xC3;
+	}
+}
+
+void InitialiseMiscEngineServerFixes(HMODULE baseAddress) 
+{
+	
 }
\ No newline at end of file