aboutsummaryrefslogtreecommitdiff
path: root/NorthstarDLL/squirrel/squirrel.cpp
diff options
context:
space:
mode:
authorJack <66967891+ASpoonPlaysGames@users.noreply.github.com>2023-01-04 21:12:53 +0000
committerGitHub <noreply@github.com>2023-01-04 21:12:53 +0000
commitefc7befe1fc6b6bdec8249e8abf6d2b7cfa1a0ff (patch)
tree3443d3710be23df70ef9695e63abe7cddfb9d35d /NorthstarDLL/squirrel/squirrel.cpp
parent4fb1ae07d8f078e7abde99900c6a8286148a380a (diff)
downloadNorthstarLauncher-efc7befe1fc6b6bdec8249e8abf6d2b7cfa1a0ff.tar.gz
NorthstarLauncher-efc7befe1fc6b6bdec8249e8abf6d2b7cfa1a0ff.zip
Improve response to UI VM compile errors (#388)
* log reaction to script compile errors * move log line to make a bit more sense * change log message and show console on non-fatal ui compile error * improve SQSharedState struct and CSquirrelVM struct Co-Authored-By: Maya <11448698+RoyalBlue1@users.noreply.github.com> * Improve IsUIVM Co-Authored-By: Maya <11448698+RoyalBlue1@users.noreply.github.com> * Remove now-unnecessary showing of console * remove extra logging Co-authored-by: Maya <11448698+RoyalBlue1@users.noreply.github.com>
Diffstat (limited to 'NorthstarDLL/squirrel/squirrel.cpp')
-rw-r--r--NorthstarDLL/squirrel/squirrel.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/NorthstarDLL/squirrel/squirrel.cpp b/NorthstarDLL/squirrel/squirrel.cpp
index 8dd93ed0..4771bf3f 100644
--- a/NorthstarDLL/squirrel/squirrel.cpp
+++ b/NorthstarDLL/squirrel/squirrel.cpp
@@ -283,8 +283,7 @@ template <ScriptContext context> void SquirrelManager<context>::AddFuncOverride(
// hooks
bool IsUIVM(ScriptContext context, HSquirrelVM* pSqvm)
{
- return context != ScriptContext::SERVER && g_pSquirrel<ScriptContext::UI>->m_pSQVM &&
- g_pSquirrel<ScriptContext::UI>->m_pSQVM->sqvm == pSqvm;
+ return ScriptContext(pSqvm->sharedState->cSquirrelVM->vmContext) == ScriptContext::UI;
}
template <ScriptContext context> void* (*__fastcall sq_compiler_create)(HSquirrelVM* sqvm, void* a2, void* a3, SQBool bShouldThrowError);
@@ -376,6 +375,7 @@ void __fastcall ScriptCompileErrorHook(HSquirrelVM* sqvm, const char* error, con
// kill dedicated server if we hit this
if (IsDedicatedServer())
{
+ logger->error("Exiting dedicated server, compile error is fatal");
// flush the logger before we exit so debug things get saved to log file
logger->flush();
exit(EXIT_FAILURE);