diff options
| author | pg9182 <96569817+pg9182@users.noreply.github.com> | 2023-04-19 18:05:59 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-19 18:05:59 -0400 |
| commit | 34af81a7d85e986f8acd7f4f10f098738a5a7c0c (patch) | |
| tree | 6a49d212a2b05d495a88defd8428ee3e5be59ce5 /NorthstarDLL/scripts/client/clientchathooks.cpp | |
| parent | e1dcf7a6b685642659c4f857b9e7f4b5ad336422 (diff) | |
| download | NorthstarLauncher-34af81a7d85e986f8acd7f4f10f098738a5a7c0c.tar.gz NorthstarLauncher-34af81a7d85e986f8acd7f4f10f098738a5a7c0c.zip | |
Fix parsing string ConVar/ConCommand.Flags from `mod.json` (#450)
Fix parsing string ConVar/ConCommand.Flags from mod.json
The ParseConVarFlagsString function introduced in 64100065b55f79e76542ba689545c60e6fb0dcef (#373)
is utterly broken. It only parses the first flag, logs misleading
warnings, has an undefined return value in some codepaths, and is
somewhat convoluted.
Luckily, this doesn't appear to affect most (if not all) existing mods,
as they all seem to be using integer values for Flags, which is
taken as-is.
https://github.com/search?q=path%3A**%2Fmod.json+ConVars+Flags&type=code
Diffstat (limited to 'NorthstarDLL/scripts/client/clientchathooks.cpp')
0 files changed, 0 insertions, 0 deletions