Code cleanup (#478)v1.16.0-rc1v1.15.1-rc1v1.15.11.15.X

* turn implicit type casts into standard compliant explicit type casts
* correct includes and library names
* correct implicit use of std-namespaced functions
* turn incomplete virtual implementations into pure virtuals (this also follows what the Source SDK tier0 header does)
* define SqRecurseArgs ahead of implementation to fix templating problems
* switch out removed getentity with getthisentity
* fix calls to curl_easy_escape with wrong types
* replace winapi-specific function with std starts_with function
* format squirrel header

1 files changed, 14 insertions, 14 deletions

diff --git a/NorthstarDLL/core/tier0.h b/NorthstarDLL/core/tier0.h
index 92a63027..eebe98f2 100644
--- a/NorthstarDLL/core/tier0.h
+++ b/NorthstarDLL/core/tier0.h
@@ -29,23 +29,23 @@ namespace Tier0
 	  public:
 		// based on the defs in the 2013 source sdk, but for some reason has an extra function (may be another CreateCmdLine overload?)
 		// these seem to line up with what they should be though
-		virtual void CreateCmdLine(const char* commandline) {}
-		virtual void CreateCmdLine(int argc, char** argv) {}
-		virtual void unknown() {}
-		virtual const char* GetCmdLine(void) const {}
+		virtual void CreateCmdLine(const char* commandline) = 0;
+		virtual void CreateCmdLine(int argc, char** argv) = 0;
+		virtual void unknown() = 0;
+		virtual const char* GetCmdLine(void) const = 0;
 
-		virtual const char* CheckParm(const char* psz, const char** ppszValue = 0) const {}
-		virtual void RemoveParm() const {}
-		virtual void AppendParm(const char* pszParm, const char* pszValues) {}
+		virtual const char* CheckParm(const char* psz, const char** ppszValue = 0) const = 0;
+		virtual void RemoveParm() const = 0;
+		virtual void AppendParm(const char* pszParm, const char* pszValues) = 0;
 
-		virtual const char* ParmValue(const char* psz, const char* pDefaultVal = 0) const {}
-		virtual int ParmValue(const char* psz, int nDefaultVal) const {}
-		virtual float ParmValue(const char* psz, float flDefaultVal) const {}
+		virtual const char* ParmValue(const char* psz, const char* pDefaultVal = 0) const = 0;
+		virtual int ParmValue(const char* psz, int nDefaultVal) const = 0;
+		virtual float ParmValue(const char* psz, float flDefaultVal) const = 0;
 
-		virtual int ParmCount() const {}
-		virtual int FindParm(const char* psz) const {}
-		virtual const char* GetParm(int nIndex) const {}
-		virtual void SetParm(int nIndex, char const* pParm) {}
+		virtual int ParmCount() const = 0;
+		virtual int FindParm(const char* psz) const = 0;
+		virtual const char* GetParm(int nIndex) const = 0;
+		virtual void SetParm(int nIndex, char const* pParm) = 0;
 
 		// virtual const char** GetParms() const {}
 	};