diff options
| author | Rémy Raes <contact@remyraes.com> | 2022-12-21 15:03:20 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-21 15:03:20 +0100 |
| commit | b9287e9ac74312b5efee8c13e3164a3352d5d09d (patch) | |
| tree | 41cd38daa060cb7fc1e121dcee9af700ca60dda9 | |
| parent | f7b508525fc1d13bafdc3f0987aa46348ac275e7 (diff) | |
| download | FlightCore-b9287e9ac74312b5efee8c13e3164a3352d5d09d.tar.gz FlightCore-b9287e9ac74312b5efee8c13e3164a3352d5d09d.zip | |
fix: Mod view with no game install (#114)
* refactor: set installedMods as a ModsView computed property
* feat: display a message on ModsView instead of cards if no mods were found
* refactor: remove error notification on game path discovery failure
* Revert "refactor: remove error notification on game path discovery failure"
This reverts commit db4af9ff78dc17bda77ce94283e35f9f1e961086.
* fix: don't invoke get_installed_mods_caller with no game path set
| -rw-r--r-- | src-vue/src/plugins/store.ts | 7 | ||||
| -rw-r--r-- | src-vue/src/views/ModsView.vue | 8 |
2 files changed, 14 insertions, 1 deletions
diff --git a/src-vue/src/plugins/store.ts b/src-vue/src/plugins/store.ts index b51f97e5..3776a6c5 100644 --- a/src-vue/src/plugins/store.ts +++ b/src-vue/src/plugins/store.ts @@ -238,6 +238,13 @@ export const store = createStore<FlightCoreStore>({ game_path: state.game_path, install_type: state.install_type } as GameInstall; + + // If there's no game path, prevent looking for installed mods. + if (state.game_path === undefined) { + console.warn('Cannot load installed mods since so game path is selected.'); + return; + } + // Call back-end for installed mods await invoke("get_installed_mods_caller", { gameInstall: game_install }) .then((message) => { diff --git a/src-vue/src/views/ModsView.vue b/src-vue/src/views/ModsView.vue index 00522bf5..b1d1aeff 100644 --- a/src-vue/src/views/ModsView.vue +++ b/src-vue/src/views/ModsView.vue @@ -3,7 +3,8 @@ <el-scrollbar> <h3>Installed Mods:</h3> <div> - <el-card shadow="hover" v-for="mod in $store.state.installed_mods"> + <p v-if="installedMods.length === 0">No mods were found.</p> + <el-card v-else shadow="hover" v-for="mod in installedMods" v-bind:key="mod.name"> <el-switch style="--el-switch-on-color: #13ce66; --el-switch-off-color: #8957e5" v-model="mod.enabled" :before-change="() => updateWhichModsEnabled(mod)" :loading="global_load_indicator" /> {{mod.name}} @@ -30,6 +31,11 @@ export default defineComponent({ async mounted() { this.$store.commit('loadInstalledMods'); }, + computed: { + installedMods(): NorthstarMod[] { + return this.$store.state.installed_mods; + } + }, methods: { async updateWhichModsEnabled(mod: NorthstarMod) { this.global_load_indicator = true; |