diff options
author | GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com> | 2023-07-23 23:32:59 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-07-23 23:32:59 +0200 |
commit | dac7b0b18ab5a36d3a25154108e9acecc6c5fe93 (patch) | |
tree | 9475ffa7d856991e1bd3d88a4950962869d42a8e | |
parent | 031ced476c38d08f7bec5312c16d1343a24e2469 (diff) | |
download | FlightCore-dac7b0b18ab5a36d3a25154108e9acecc6c5fe93.tar.gz FlightCore-dac7b0b18ab5a36d3a25154108e9acecc6c5fe93.zip |
feat: Add basic warning on plugin install (#441)
Plugins in Northstar have unrestricted device access.
As such we want to warn user before installing one with an option to abort.
-rw-r--r-- | src-tauri/src/mod_management/mod.rs | 7 | ||||
-rw-r--r-- | src-tauri/src/mod_management/plugins.rs | 26 |
2 files changed, 31 insertions, 2 deletions
diff --git a/src-tauri/src/mod_management/mod.rs b/src-tauri/src/mod_management/mod.rs index 0d4edd87..879d3b04 100644 --- a/src-tauri/src/mod_management/mod.rs +++ b/src-tauri/src/mod_management/mod.rs @@ -12,6 +12,7 @@ use std::string::ToString; use std::{fs, path::PathBuf}; mod legacy; +mod plugins; use crate::GameInstall; #[derive(Debug, Clone)] @@ -498,8 +499,10 @@ fn fc_sanity_check(input: &&fs::File) -> bool { if file_path.starts_with("plugins/") { if let Some(name) = file_path.file_name() { if name.to_str().unwrap().contains(".dll") { - log::warn!("Plugin detected, skipping"); - return false; // We disallow plugins for now + log::warn!("Plugin detected, prompting user"); + if !plugins::plugin_prompt() { + return false; // Plugin detected and user denied install + } } } } diff --git a/src-tauri/src/mod_management/plugins.rs b/src-tauri/src/mod_management/plugins.rs new file mode 100644 index 00000000..e2427a16 --- /dev/null +++ b/src-tauri/src/mod_management/plugins.rs @@ -0,0 +1,26 @@ +use tauri::api::dialog::blocking::MessageDialogBuilder; +use tauri::api::dialog::{MessageDialogButtons, MessageDialogKind}; + +/// Prompt on plugin +/// Returns: +/// - true: user accepted plugin install +/// - false: user denied plugin install +pub fn plugin_prompt() -> bool { + let dialog = MessageDialogBuilder::new( + "Plugin in package detected", + "This mod contains a plugin. Plugins have unrestricted access to your computer! + \nMake sure you trust the author! + \n + \nPress 'Ok' to continue or 'Cancel' to abort mod installation", + ) + .kind(MessageDialogKind::Warning) + .buttons(MessageDialogButtons::OkCancel); + + if dialog.show() { + log::info!("Accepted plugin install"); + true + } else { + log::warn!("Plugin install cancelled"); + false + } +} |