From 16fa255f48ae2d290bc26ceb41489f2c3e21b96d Mon Sep 17 00:00:00 2001 From: Marc Tiehuis Date: Wed, 21 Aug 2019 21:34:42 +1200 Subject: Inline full slice hashing This gives moderate speed improvements when hashing small keys. The crc/adler/fnv inlining did not provide enough speed up to warrant the change. OLD: wyhash small keys: 2277 MiB/s [c14617a1e3800000] siphash(1,3) small keys: 937 MiB/s [b2919222ed400000] siphash(2,4) small keys: 722 MiB/s [3c3d974cc2800000] fnv1a small keys: 1580 MiB/s [70155e1cb7000000] adler32 small keys: 1898 MiB/s [00013883ef800000] crc32-slicing-by-8 small keys: 2323 MiB/s [0035bf3dcac00000] crc32-half-byte-lookup small keys: 218 MiB/s [0035bf3dcac00000] NEW: wyhash small keys: 2775 MiB/s [c14617a1e3800000] siphash(1,3) small keys: 1086 MiB/s [b2919222ed400000] siphash(2,4) small keys: 789 MiB/s [3c3d974cc2800000] fnv1a small keys: 1604 MiB/s [70155e1cb7000000] adler32 small keys: 1856 MiB/s [00013883ef800000] crc32-slicing-by-8 small keys: 2336 MiB/s [0035bf3dcac00000] crc32-half-byte-lookup small keys: 218 MiB/s [0035bf3dcac00000] --- std/hash/siphash.zig | 4 ++-- std/hash/wyhash.zig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'std/hash') diff --git a/std/hash/siphash.zig b/std/hash/siphash.zig index 8e83d67897..aa38c61863 100644 --- a/std/hash/siphash.zig +++ b/std/hash/siphash.zig @@ -152,8 +152,8 @@ fn SipHash(comptime T: type, comptime c_rounds: usize, comptime d_rounds: usize) pub fn hash(key: []const u8, input: []const u8) T { var c = Self.init(key); - c.update(input); - return c.final(); + @inlineCall(c.update, input); + return @inlineCall(c.final); } }; } diff --git a/std/hash/wyhash.zig b/std/hash/wyhash.zig index dfa5156cad..f5cca121f4 100644 --- a/std/hash/wyhash.zig +++ b/std/hash/wyhash.zig @@ -116,8 +116,8 @@ pub const Wyhash = struct { pub fn hash(seed: u64, input: []const u8) u64 { var c = Wyhash.init(seed); - c.update(input); - return c.final(); + @inlineCall(c.update, input); + return @inlineCall(c.final); } }; -- cgit v1.2.3