From e2a8fe721dbf31a8edd06c8273bee8a8e69381f2 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Sun, 7 Jan 2024 16:18:18 -0700 Subject: mingw: add comments so that I don't regress this code later MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Martin Storsjö kindly took the time to discuss things at length with me, and the results are that this status quo is correct. I added comments so that I don't think it should be changed later. --- src/mingw.zig | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/mingw.zig b/src/mingw.zig index 68488546dc..5a4e6b54cb 100644 --- a/src/mingw.zig +++ b/src/mingw.zig @@ -87,6 +87,9 @@ pub fn buildCRTFile(comp: *Compilation, crt_file: CRTFile, prog_node: *std.Progr "-std=gnu99", "-D_CRTBLD", + // According to Martin Storsjö, + // > the files under mingw-w64-crt are designed to always + // be built with __MSVCRT_VERSION__=0x700 "-D__MSVCRT_VERSION__=0x700", "-D__USE_MINGW_ANSI_STDIO=0", }); @@ -113,9 +116,11 @@ pub fn buildCRTFile(comp: *Compilation, crt_file: CRTFile, prog_node: *std.Progr "-std=gnu99", "-D_CRTBLD", + // According to Martin Storsjö, + // > the files under mingw-w64-crt are designed to always + // be built with __MSVCRT_VERSION__=0x700 "-D__MSVCRT_VERSION__=0x700", "-D__USE_MINGW_ANSI_STDIO=0", - "-isystem", try comp.zig_lib_directory.join(arena, &[_][]const u8{ "libc", "include", "any-windows-any" }), }); @@ -179,9 +184,11 @@ pub fn buildCRTFile(comp: *Compilation, crt_file: CRTFile, prog_node: *std.Progr "-std=gnu99", "-D_CRTBLD", + // According to Martin Storsjö, + // > the files under mingw-w64-crt are designed to always + // be built with __MSVCRT_VERSION__=0x700 "-D__MSVCRT_VERSION__=0x700", "-D__USE_MINGW_ANSI_STDIO=0", - "-isystem", try comp.zig_lib_directory.join(arena, &[_][]const u8{ "libc", "include", "any-windows-any", @@ -225,6 +232,9 @@ fn add_cc_args( try args.appendSlice(&[_][]const u8{ "-std=gnu11", "-D_CRTBLD", + // According to Martin Storsjö, + // > the files under mingw-w64-crt are designed to always + // be built with __MSVCRT_VERSION__=0x700 "-D__MSVCRT_VERSION__=0x700", "-D__USE_MINGW_ANSI_STDIO=0", }); -- cgit v1.2.3