From c64f6f950343aef3c6d8fbffcff3ff4fc76960f4 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Thu, 22 Sep 2016 10:40:05 -0400 Subject: fix compile crash when leaving out for loop parameter --- src/analyze.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/analyze.cpp b/src/analyze.cpp index f38459528b..bae41742b4 100644 --- a/src/analyze.cpp +++ b/src/analyze.cpp @@ -4164,6 +4164,12 @@ static TypeTableEntry *analyze_for_expr(CodeGen *g, ImportTableEntry *import, Bl child_context->parent_loop_node = node; AstNode *elem_var_node = node->data.for_expr.elem_node; + if (!elem_var_node) { + add_node_error(g, node->data.for_expr.body, + buf_sprintf("for loop expression missing element parameter")); + return g->builtin_types.entry_invalid; + } + elem_var_node->block_context = child_context; Buf *elem_var_name = elem_var_node->data.symbol_expr.symbol; node->data.for_expr.elem_var = add_local_var(g, elem_var_node, import, child_context, elem_var_name, @@ -4180,8 +4186,7 @@ static TypeTableEntry *analyze_for_expr(CodeGen *g, ImportTableEntry *import, Bl g->builtin_types.entry_usize, true, nullptr); } - AstNode *for_body_node = node->data.for_expr.body; - analyze_expression(g, import, child_context, g->builtin_types.entry_void, for_body_node); + analyze_expression(g, import, child_context, g->builtin_types.entry_void, node->data.for_expr.body); return g->builtin_types.entry_void; -- cgit v1.2.3