From 88aec4a1ee49088685b16d744f35c902c4900a09 Mon Sep 17 00:00:00 2001 From: Jakub Konka Date: Tue, 8 Jun 2021 23:23:31 +0200 Subject: zld: work out size and alignment of commons --- src/link/MachO/Object.zig | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/link/MachO/Object.zig b/src/link/MachO/Object.zig index 2662072758..5241fea582 100644 --- a/src/link/MachO/Object.zig +++ b/src/link/MachO/Object.zig @@ -383,11 +383,10 @@ pub fn parseSymbols(self: *Object) !void { } if (sym.n_value != 0) { - log.err("common symbol {s} in {s}", .{ sym_name, self.name.? }); + const comm_size = sym.n_value; + const comm_align = (sym.n_desc >> 8) & 0x0f; + log.err("Common symbol {s} in {s}: size 0x{x}, align 0x{x}", .{ sym_name, self.name.?, comm_size, comm_align }); return error.UnhandledSymbolType; - // const comm_size = sym.n_value; - // const comm_align = (sym.n_desc >> 8) & 0x0f; - // log.warn("Common symbol: size 0x{x}, align 0x{x}", .{ comm_size, comm_align }); } const undef = try self.allocator.create(Symbol.Unresolved); -- cgit v1.2.3