From 15dddfd84d9007689ef1fa6f4abedb88c570973a Mon Sep 17 00:00:00 2001 From: Veikka Tuominen Date: Fri, 22 Jul 2022 13:20:18 +0300 Subject: AstGen: make comptime fields in packed and extern structs compile errors --- src/AstGen.zig | 6 ++++++ src/Sema.zig | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/AstGen.zig b/src/AstGen.zig index fa1f72670a..6df27d6983 100644 --- a/src/AstGen.zig +++ b/src/AstGen.zig @@ -4214,6 +4214,12 @@ fn structDeclInner( const have_value = member.ast.value_expr != 0; const is_comptime = member.comptime_token != null; + if (is_comptime and layout == .Packed) { + return astgen.failTok(member.comptime_token.?, "packed struct fields cannot be marked comptime", .{}); + } else if (is_comptime and layout == .Extern) { + return astgen.failTok(member.comptime_token.?, "extern struct fields cannot be marked comptime", .{}); + } + if (!is_comptime) { known_non_opv = known_non_opv or nodeImpliesMoreThanOnePossibleValue(tree, member.ast.type_expr); diff --git a/src/Sema.zig b/src/Sema.zig index fd630e88bf..ecb387ed34 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -14509,6 +14509,7 @@ fn zirStructInit( var field_i: u32 = 0; var extra_index = extra.end; + const is_packed = resolved_ty.containerLayout() == .Packed; while (field_i < extra.data.fields_len) : (field_i += 1) { const item = sema.code.extraData(Zir.Inst.StructInit.Item, extra_index); extra_index = item.end; @@ -14535,7 +14536,7 @@ fn zirStructInit( } found_fields[field_index] = item.data.field_type; field_inits[field_index] = try sema.resolveInst(item.data.init); - if (resolved_ty.structFieldValueComptime(field_index)) |default_value| { + if (!is_packed) if (resolved_ty.structFieldValueComptime(field_index)) |default_value| { const init_val = (try sema.resolveMaybeUndefVal(block, field_src, field_inits[field_index])) orelse { return sema.failWithNeededComptime(block, field_src, "value stored in comptime field must be comptime known"); }; @@ -14544,7 +14545,7 @@ fn zirStructInit( // TODO add note showing where default value is provided return sema.fail(block, field_src, "value stored in comptime field does not match the default value of the field", .{}); } - } + }; } return sema.finishStructInit(block, src, src, field_inits, resolved_ty, is_ref); -- cgit v1.2.3