From 240d0b68f62c4fd3562649ec7fc29a51be3698d7 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Tue, 27 Feb 2024 22:06:11 -0700 Subject: make aro-based translate-c lazily built from source Part of #19063. Primarily, this moves Aro from deps/ to lib/compiler/ so that it can be lazily compiled from source. src/aro_translate_c.zig is moved to lib/compiler/aro_translate_c.zig and some of Zig CLI logic moved to a main() function there. aro_translate_c.zig becomes the "common" import for clang-based translate-c. Not all of the compiler was able to be detangled from Aro, however, so it still, for now, remains being compiled with the main compiler sources due to the clang-based translate-c depending on it. Once aro-based translate-c achieves feature parity with the clang-based translate-c implementation, the clang-based one can be removed from Zig. Aro made it unnecessarily difficult to depend on with these .def files and all these Zig module requirements. I looked at the .def files and made these observations: - The canonical source is llvm .def files. - Therefore there is an update process to sync with llvm that involves regenerating the .def files in Aro. - Therefore you might as well just regenerate the .zig files directly and check those into Aro. - Also with a small amount of tinkering, the file size on disk of these generated .zig files can be made many times smaller, without compromising type safety in the usage of the data. This would make things much easier on Zig as downstream project, particularly we could remove those pesky stubs when bootstrapping. I have gone ahead with these changes since they unblock me and I will have a chat with Vexu to see what he thinks. --- src/Compilation.zig | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/Compilation.zig') diff --git a/src/Compilation.zig b/src/Compilation.zig index 58413f7c9e..78330b6806 100644 --- a/src/Compilation.zig +++ b/src/Compilation.zig @@ -4007,8 +4007,6 @@ pub fn cImport(comp: *Compilation, c_src: []const u8, owner_mod: *Package.Module } var tree = switch (comp.config.c_frontend) { .aro => tree: { - const translate_c = @import("aro_translate_c.zig"); - _ = translate_c; if (true) @panic("TODO"); break :tree undefined; }, -- cgit v1.2.3