From c6fbe0d5d89a7b2665a0afa7fad23027fd0b87ca Mon Sep 17 00:00:00 2001 From: Robin Voetter Date: Fri, 25 Nov 2022 14:58:14 +0100 Subject: dont destroy old bin file on link openpath failure This was causing some crashes. --- src/Compilation.zig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/Compilation.zig') diff --git a/src/Compilation.zig b/src/Compilation.zig index f6f4851e5e..caa572e29d 100644 --- a/src/Compilation.zig +++ b/src/Compilation.zig @@ -1948,8 +1948,9 @@ pub fn update(comp: *Compilation, main_progress_node: *std.Progress.Node) !void .sub_path = std.fs.path.basename(sub_path), }; } - comp.bin_file.destroy(); + var old_bin_file = comp.bin_file; comp.bin_file = try link.File.openPath(comp.gpa, options); + old_bin_file.destroy(); } // For compiling C objects, we rely on the cache hash system to avoid duplicating work. -- cgit v1.2.3