From 8bd94759bf48c3247d4de14806ff2f510cb36591 Mon Sep 17 00:00:00 2001 From: John Schmidt Date: Sun, 18 Feb 2024 01:06:13 +0100 Subject: Sema: evaluate generic instantiations in fn decls capture scope The generic call `S.foo()` was evaluated with the capture scope of the owner decl (i.e the `test` block), when it should use the capture scope of the function declaration. --- src/Sema.zig | 2 +- test/behavior/generics.zig | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/Sema.zig b/src/Sema.zig index 741c4e2fba..e0a8d1fe00 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -7951,7 +7951,7 @@ fn instantiateGenericCall( .sema = &child_sema, .src_decl = generic_owner_func.owner_decl, .namespace = namespace_index, - .wip_capture_scope = try mod.createCaptureScope(sema.owner_decl.src_scope), + .wip_capture_scope = try mod.createCaptureScope(fn_owner_decl.src_scope), .instructions = .{}, .inlining = null, .is_comptime = true, diff --git a/test/behavior/generics.zig b/test/behavior/generics.zig index f50e6bf7f4..aca76ece58 100644 --- a/test/behavior/generics.zig +++ b/test/behavior/generics.zig @@ -558,3 +558,19 @@ test "call generic function with from function called by the generic function" { ArgSerializer.serializeCommand(GET{ .key = "banana" }); } + +fn StructCapture(comptime T: type) type { + return struct { + pub fn foo(comptime x: usize) struct { T } { + return .{x}; + } + }; +} + +test "call generic function that uses capture from function declaration's scope" { + if (builtin.zig_backend == .stage2_x86_64 and builtin.target.ofmt != .elf and builtin.target.ofmt != .macho) return error.SkipZigTest; + + const S = StructCapture(f64); + const s = S.foo(123); + try expectEqual(123.0, s[0]); +} -- cgit v1.2.3