Add Mod Settings (#518)

* Add Mod Settings

* Make rounding optional

* Add recursive search

* too much shit

Add custom buttons, expand menu further, sanitize display names, cleanup, add more descriptive errors and throw them early, rework slightly func params

* Remove Test Stuff

* Clean-Up

* Revert mod version change

* Replace GetIndex with PureModulo

better, more understandable version of the function.

* Fix Slider bug

* Fix Localization

* Add eject quotes (#527)

* Upload cl_titan_cockpit.nut

* Add eject string in script

* Moved to client

* index issue + removed else so always returns

* Apply suggestions from code review

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Rest of the suggestions 

because github makes me want to cry

* Commit suggestions from review

GitHub really hates batching suggestions

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Update localization

* Update Northstar.Client/mod/scripts/vscripts/ui/menu_mod_settings.nut

From ASpoonPlaysGames

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Update Northstar.Client/mod.json

From ASpoonPlaysames

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Update Northstar.Client/mod/scripts/vscripts/ui/menu_mod_settings.nut

From ASpoonPlaysGames

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Delete cl_titan_cockpit.nut

* Apply suggestions from Spoon's code review

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Formatting for ModSettings + Remove Base Northstar Settings (#1)

* fix formatting

* add newline

* formatting part 1

* formatting part 2

* formatting again

Co-authored-by: EladNLG <e1lad8955@gmail.com>

* reset vmt (#2)

* reset vmt

* formatting

* more formatting

* Fixes, color modification

* Fix Image behind button & make image clickable

using a hack because imagepanels don't get click events and i hate them

* Formatting Fixes The First

* Apply suggestions from Spoon's review

Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>

* Formatting Fixes The Second

* Fix reset popup appearing when not clicking on button

* Fix only being able to type 1 char at a time

* Fix more bugs

- never being able to get out of modsettings dialogs
- setting duplication glitch

* Fix alignment

* add no results/mods (need localization)

* he forgor :(

make addmodsettingsbutton global

Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>

* Clean up (thanks @uniboi)

Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>

* forgot to add this too

Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>

* Mod settings submenus (#4)

* allow for submenu closing

* hide reset vgui on buttons

* My code got GECKO'd

gecko suggestions

Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>

* uniboi fixing his own mistakes moment + more prints removed (thanks @uniboi)

Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>

* aaaaaaaa

Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>

* rename ms_slider

* add a newline

* add temporary aliases

* fix aliases and localization

* update button width for categories

* fix resets accessing out of bounds index

* allow unicode search

* use correct index variable

* update function names

---------

Co-authored-by: JMM889901 <41163714+JMM889901@users.noreply.github.com>
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
Co-authored-by: uniboi <plurals@autism.exposed>
Co-authored-by: uniboi <kami.0.katze@gmail.com>

1 files changed, 12 insertions, 3 deletions

diff --git a/Northstar.Client/mod/scripts/vscripts/ui/menu_ingame.nut b/Northstar.Client/mod/scripts/vscripts/ui/menu_ingame.nut
index 03bd8959..35c9e9ba 100644
--- a/Northstar.Client/mod/scripts/vscripts/ui/menu_ingame.nut
+++ b/Northstar.Client/mod/scripts/vscripts/ui/menu_ingame.nut
@@ -112,8 +112,13 @@ void function InitInGameMPMenu()
 		Hud_AddEventHandler( soundButton, UIE_CLICK, AdvanceMenuEventHandler( GetMenu( "VideoMenu" ) ) )
 	#endif
 
-	file.faqButton = AddComboButton( comboStruct, headerIndex, buttonIndex++, "#KNB_MENU_HEADER" )
-	Hud_AddEventHandler( file.faqButton, UIE_CLICK, AdvanceMenuEventHandler( GetMenu( "KnowledgeBaseMenu" ) ) )
+	// MOD SETTINGS
+	var modSettingsButton = AddComboButton( comboStruct, headerIndex, buttonIndex++, "Mod Settings" )
+	Hud_AddEventHandler( modSettingsButton, UIE_CLICK, AdvanceMenuEventHandler( GetMenu( "ModSettings" ) ) )
+
+	// Nobody reads the FAQ so we replace it with ModSettings because of the limited combobutton space available
+	//file.faqButton = AddComboButton( comboStruct, headerIndex, buttonIndex++, "#KNB_MENU_HEADER" )
+	//Hud_AddEventHandler( file.faqButton, UIE_CLICK, AdvanceMenuEventHandler( GetMenu( "KnowledgeBaseMenu" ) ) )
 
 	//var dataCenterButton = AddComboButton( comboStruct, headerIndex, buttonIndex++, "#DATA_CENTER" )
 	//Hud_AddEventHandler( dataCenterButton, UIE_CLICK, OpenDataCenterDialog )
@@ -133,7 +138,7 @@ void function OnInGameMPMenu_Open()
 
 	bool faqIsNew = !GetConVarBool( "menu_faq_viewed" ) || HaveNewPatchNotes() || HaveNewCommunityNotes()
 	RuiSetBool( Hud_GetRui( file.settingsHeader ), "isNew", faqIsNew )
-	ComboButton_SetNew( file.faqButton, faqIsNew )
+	//ComboButton_SetNew( file.faqButton, faqIsNew )
 
 	UpdateLoadoutButtons()
 	RefreshCreditsAvailable()
@@ -255,6 +260,10 @@ void function InitInGameSPMenu()
 		var videoButton = AddComboButton( comboStruct, headerIndex, buttonIndex++, "#VIDEO" )
 		Hud_AddEventHandler( videoButton, UIE_CLICK, AdvanceMenuEventHandler( GetMenu( "VideoMenu" ) ) )
 	#endif
+	
+	// MOD SETTINGS
+	var modSettingsButton = AddComboButton( comboStruct, headerIndex, buttonIndex++, "Mod Settings" )
+	Hud_AddEventHandler( modSettingsButton, UIE_CLICK, AdvanceMenuEventHandler( GetMenu( "ModSettings" ) ) )
 
 	array<var> orderedButtons