From 85a2fb9c56c1942958c09c8aeafd14ddefb6e0c3 Mon Sep 17 00:00:00 2001
From: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Date: Mon, 4 Mar 2024 00:12:05 +0000
Subject: Address C4100 compiler warnings (unused var) (#648)

Adds and uses a macro to avoid the warning
---
 primedev/logging/logging.cpp       | 1 +
 primedev/logging/logging.h         | 1 +
 primedev/logging/loghooks.cpp      | 5 +++++
 primedev/logging/sourceconsole.cpp | 4 ++++
 4 files changed, 11 insertions(+)

(limited to 'primedev/logging')

diff --git a/primedev/logging/logging.cpp b/primedev/logging/logging.cpp
index ef9a6737..72171e25 100644
--- a/primedev/logging/logging.cpp
+++ b/primedev/logging/logging.cpp
@@ -70,6 +70,7 @@ void CreateLogFiles()
 
 void ExternalConsoleSink::sink_it_(const spdlog::details::log_msg& msg)
 {
+	NOTE_UNUSED(msg);
 	throw std::runtime_error("sink_it_ called on SourceConsoleSink with pure log_msg. This is an error!");
 }
 
diff --git a/primedev/logging/logging.h b/primedev/logging/logging.h
index 5056af27..be41cb39 100644
--- a/primedev/logging/logging.h
+++ b/primedev/logging/logging.h
@@ -25,6 +25,7 @@ public:
 	void custom_log(const custom_log_msg& msg);
 	virtual void custom_sink_it_(const custom_log_msg& msg)
 	{
+		NOTE_UNUSED(msg);
 		throw std::runtime_error("Pure virtual call to CustomSink::custom_sink_it_");
 	}
 };
diff --git a/primedev/logging/loghooks.cpp b/primedev/logging/loghooks.cpp
index 7efb5b99..dcd9b85a 100644
--- a/primedev/logging/loghooks.cpp
+++ b/primedev/logging/loghooks.cpp
@@ -108,6 +108,8 @@ AUTOHOOK(Hook_fprintf, engine.dll + 0x51B1F0,
 int,, (void* const stream, const char* const format, ...))
 // clang-format on
 {
+	NOTE_UNUSED(stream);
+
 	va_list va;
 	va_start(va, format);
 
@@ -139,6 +141,7 @@ AUTOHOOK(EngineSpewFunc, engine.dll + 0x11CA80,
 void, __fastcall, (void* pEngineServer, SpewType_t type, const char* format, va_list args))
 // clang-format on
 {
+	NOTE_UNUSED(pEngineServer);
 	if (!Cvar_spewlog_enable->GetBool())
 		return;
 
@@ -235,6 +238,8 @@ AUTOHOOK(CClientState_ProcessPrint, engine.dll + 0x1A1530,
 bool,, (void* thisptr, uintptr_t msg))
 // clang-format on
 {
+	NOTE_UNUSED(thisptr);
+
 	char* text = *(char**)(msg + 0x20);
 
 	auto endpos = strlen(text);
diff --git a/primedev/logging/sourceconsole.cpp b/primedev/logging/sourceconsole.cpp
index e436d1d4..55be4723 100644
--- a/primedev/logging/sourceconsole.cpp
+++ b/primedev/logging/sourceconsole.cpp
@@ -8,6 +8,7 @@ SourceInterface<CGameConsole>* g_pSourceGameConsole;
 
 void ConCommand_toggleconsole(const CCommand& arg)
 {
+	NOTE_UNUSED(arg);
 	if ((*g_pSourceGameConsole)->IsConsoleVisible())
 		(*g_pSourceGameConsole)->Hide();
 	else
@@ -16,11 +17,13 @@ void ConCommand_toggleconsole(const CCommand& arg)
 
 void ConCommand_showconsole(const CCommand& arg)
 {
+	NOTE_UNUSED(arg);
 	(*g_pSourceGameConsole)->Activate();
 }
 
 void ConCommand_hideconsole(const CCommand& arg)
 {
+	NOTE_UNUSED(arg);
 	(*g_pSourceGameConsole)->Hide();
 }
 
@@ -47,6 +50,7 @@ void SourceConsoleSink::custom_sink_it_(const custom_log_msg& msg)
 
 void SourceConsoleSink::sink_it_(const spdlog::details::log_msg& msg)
 {
+	NOTE_UNUSED(msg);
 	throw std::runtime_error("sink_it_ called on SourceConsoleSink with pure log_msg. This is an error!");
 }
 
-- 
cgit v1.2.3