From 379cbc8bc251307777a14b901e5617e834398485 Mon Sep 17 00:00:00 2001
From: KittenPopo <Pokeberry123@gmail.com>
Date: Sat, 26 Mar 2022 16:20:09 -0700
Subject: Major exploit fixes and some minor bug fixes/improvements (#117)

* Added main exploit fixes

* Fixed typo in sigscanning.cpp

* Fully implemented

* Added proper includes for new files

* Update README.md

* typo

* spare me my sanity (fixed ridiculous code)

* Added rest of KittenMemUtils

* Rename KittenMemUtils

* Removed all messy memory edits, implemented NSMem instead

* Update NorthstarDedicatedTest.vcxproj

* [1] Move everything from securitypatches to ExploitFixes

* [2] Move everything from securitypatches to ExploitFixes

* Fixed module offsets in stack trace

* Fixed UTF8 Parsing (Multiplayer Crash)

* Implemented UT8 fix

* Update NorthstarDedicatedTest.vcxproj

* Update hookutils.cpp

* Small fixes

* all my homies hate clang-format

* Temporarily restore README.md

* Added string hash macro

* Added convenient vtfunc macro

* Made lil ConCommand creation macro

* Fixed multiple NET_SetConVar exploits

* Quick fixerino

* Fix convar struct (and other things)

* Revive clang-format (but good, i think)

* Update .clang-format

* Reformatted code to meet .clang-format requirements

* Minor formatting fixes

* Fixed Northstar "crashing" when console is closed

* Update .clang-format
---
 NorthstarDedicatedTest/misccommands.cpp | 73 +++++++++++++++------------------
 1 file changed, 33 insertions(+), 40 deletions(-)

(limited to 'NorthstarDedicatedTest/misccommands.cpp')

diff --git a/NorthstarDedicatedTest/misccommands.cpp b/NorthstarDedicatedTest/misccommands.cpp
index 4a556fad..dca87947 100644
--- a/NorthstarDedicatedTest/misccommands.cpp
+++ b/NorthstarDedicatedTest/misccommands.cpp
@@ -6,50 +6,43 @@
 #include "serverauthentication.h"
 #include "squirrel.h"
 
-void ForceLoadMapCommand(const CCommand& arg)
+void AddMiscConCommands()
 {
-	if (arg.ArgC() < 2)
-		return;
-
-	g_pHostState->m_iNextState = HS_NEW_GAME;
-	strncpy(g_pHostState->m_levelName, arg.Arg(1), sizeof(g_pHostState->m_levelName));
-}
+	MAKE_CONCMD(
+		"force_newgame", "forces a map load through directly setting g_pHostState->m_iNextState to HS_NEW_GAME", FCVAR_NONE,
+		[](const CCommand& arg) {
+			if (arg.ArgC() < 2)
+				return;
 
-void SelfAuthAndLeaveToLobbyCommand(const CCommand& arg)
-{
-	// hack for special case where we're on a local server, so we erase our own newly created auth data on disconnect
+			g_pHostState->m_iNextState = HS_NEW_GAME;
+			strncpy(g_pHostState->m_levelName, arg.Arg(1), sizeof(g_pHostState->m_levelName));
+		});
 
-	g_MasterServerManager->m_bNewgameAfterSelfAuth = true;
-	g_MasterServerManager->AuthenticateWithOwnServer(g_LocalPlayerUserID, g_MasterServerManager->m_ownClientAuthToken);
-}
+	MAKE_CONCMD(
+		"ns_start_reauth_and_leave_to_lobby", "called by the server, used to reauth and return the player to lobby when leaving a game",
+		FCVAR_SERVER_CAN_EXECUTE, [](const CCommand& arg) {
+			// hack for special case where we're on a local server, so we erase our own newly created auth data on disconnect
+			g_MasterServerManager->m_bNewgameAfterSelfAuth = true;
+			g_MasterServerManager->AuthenticateWithOwnServer(g_LocalPlayerUserID, g_MasterServerManager->m_ownClientAuthToken);
+		});
 
-void EndSelfAuthAndLeaveToLobbyCommand(const CCommand& arg)
-{
-	Cbuf_AddText(
-		Cbuf_GetCurrentPlayer(), fmt::format("serverfilter {}", g_ServerAuthenticationManager->m_authData.begin()->first).c_str(),
-		cmd_source_t::kCommandSrcCode);
-	Cbuf_Execute();
+	// this is a concommand because we make a deferred call to it from another thread
+	MAKE_CONCMD("ns_end_reauth_and_leave_to_lobby", "", FCVAR_NONE, [](const CCommand& arg) {
+		Cbuf_AddText(
+			Cbuf_GetCurrentPlayer(), fmt::format("serverfilter {}", g_ServerAuthenticationManager->m_authData.begin()->first).c_str(),
+			cmd_source_t::kCommandSrcCode);
+		Cbuf_Execute();
 
-	// weird way of checking, but check if client script vm is initialised, mainly just to allow players to cancel this
-	if (g_ClientSquirrelManager->sqvm)
-	{
-		g_ServerAuthenticationManager->m_bNeedLocalAuthForNewgame = true;
-		// this won't set playlist correctly on remote clients, don't think they can set playlist until they've left which sorta fucks
-		// things should maybe set this in HostState_NewGame?
-		SetCurrentPlaylist("tdm");
-		strcpy(g_pHostState->m_levelName, "mp_lobby");
-		g_pHostState->m_iNextState = HS_NEW_GAME;
-	}
-}
+		// weird way of checking, but check if client script vm is initialised, mainly just to allow players to cancel this
+		if (g_ClientSquirrelManager->sqvm)
+		{
+			g_ServerAuthenticationManager->m_bNeedLocalAuthForNewgame = true;
 
-void AddMiscConCommands()
-{
-	RegisterConCommand(
-		"force_newgame", ForceLoadMapCommand, "forces a map load through directly setting g_pHostState->m_iNextState to HS_NEW_GAME",
-		FCVAR_NONE);
-	RegisterConCommand(
-		"ns_start_reauth_and_leave_to_lobby", SelfAuthAndLeaveToLobbyCommand,
-		"called by the server, used to reauth and return the player to lobby when leaving a game", FCVAR_SERVER_CAN_EXECUTE);
-	// this is a concommand because we make a deferred call to it from another thread
-	RegisterConCommand("ns_end_reauth_and_leave_to_lobby", EndSelfAuthAndLeaveToLobbyCommand, "", FCVAR_NONE);
+			// this won't set playlist correctly on remote clients, don't think they can set playlist until they've left which sorta fucks
+			// things should maybe set this in HostState_NewGame?
+			SetCurrentPlaylist("tdm");
+			strcpy(g_pHostState->m_levelName, "mp_lobby");
+			g_pHostState->m_iNextState = HS_NEW_GAME;
+		}
+	});
 }
\ No newline at end of file
-- 
cgit v1.2.3